Skip to content

Do not use app object when testing a package #313

Open
@schloerke

Description

@schloerke

From #307 (comment)

Am I correct that the main three cases we care about are:

  1. Writing tests for a nontrivial app that is in an app.R
  2. Writing tests for a nontrivial app that is using golem/rhino(?)
  3. Writing tests for trivial apps that exercise some feature or component that is not specific to a single app

The kind of cross-process de/serialization that this PR is fixing, totally makes sense to me for case 3. It makes me a lot less comfortable if people are relying on it for case 2. I'd love to see us make a formal recommendation for using shinytest2 with golem/rhino that doesn't involve serializing any code objects.

Metadata

Metadata

Assignees

No one assigned

    Labels

    documentationImprovements or additions to documentationtheme: package / golem / rhinoTesting a R package vs a shiny directorytheme: testthat file loadingCould be fixed if testthat file loading was used in shiny process

    Type

    No type

    Projects

    No projects

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions