Merge tag '3.9.3' into rti_main

Author: angelrti

.clang-format

@@ -8,12 +8,11 @@ AllowAllParametersOfDeclarationOnNextLine: false
 AllowShortIfStatementsOnASingleLine: false
 AllowShortLoopsOnASingleLine: false
 AllowShortFunctionsOnASingleLine: None
-AllowShortLoopsOnASingleLine: false
 AlwaysBreakTemplateDeclarations: true
 AlwaysBreakBeforeMultilineStrings: false
 BreakBeforeBinaryOperators: false
 BreakBeforeTernaryOperators: false
-BreakConstructorInitializersBeforeComma: true
+BreakConstructorInitializers: BeforeComma
 BinPackParameters: true
 ColumnLimit: 90
 ConstructorInitializerAllOnOneLineOrOnePerLine: true
@@ -52,16 +51,15 @@ BreakBeforeBraces: Custom
 
 # Control of individual brace wrapping cases
 BraceWrapping: {
-    AfterClass: 'true'
-    AfterControlStatement: 'true'
-    AfterEnum : 'true'
-    AfterFunction : 'true'
-    AfterNamespace : 'true'
-    AfterStruct : 'true'
-    AfterUnion : 'true'
-    BeforeCatch : 'true'
-    BeforeElse : 'true'
+    AfterClass: 'true',
+    AfterControlStatement: 'true',
+    AfterEnum : 'true',
+    AfterFunction : 'true',
+    AfterNamespace : 'true',
+    AfterStruct : 'true',
+    AfterUnion : 'true',
+    BeforeCatch : 'true',
+    BeforeElse : 'true',
     IndentBraces : 'false'
 }
 ...
-

.dockerignore

@@ -0,0 +1,2 @@
+Dockerfile
+.git/

.github/ISSUE_TEMPLATE.md

@@ -1,12 +1,10 @@
-Thanks for contributing to PlotJuggler. You are great!
-
 # Problem description
 
-Describe the problem and the expected behavior. Use screenshots of video if approriate.
-
-# Steps to reproduce (important)
+Describe the problem and the expected behavior. Use screenshots or a video, if applicable.
 
-- Describe your platform / Operative System.
-- Check if the problem can be reproduced using the dummy data created by the command line argument "-t" or one of the files in the folder "datasamples".
-- If it can't be reproduced with the dummy data, __please__ share the CSV file or the rosbag that can be used to reproduce the problem.
+# Answer these questions (or I will ignore your issue)
 
+1. Describe your platform / Operative System and the **version of PlotJuggler** you are using.
+2. Compile and try the latest version in the **main** branch and check if the problem persists.
+3. Check if the problem can be reproduced using the dummy data created by the command line argument "-t" or one of the files in the folder "datasamples".
+4. If it can't be reproduced with the dummy data, __please__ share the CSV file or the rosbag that can be used to reproduce the problem.

.github/workflows/codeql.yml

@@ -0,0 +1,75 @@
+name: "CodeQL"
+
+on:
+  push:
+    branches: [ 'main' ]
+  pull_request:
+    # The branches below must be a subset of the branches above
+    branches: [ 'main' ]
+  schedule:
+    - cron: '28 15 * * 2'
+
+jobs:
+  analyze:
+    name: Analyze
+    runs-on: ubuntu-latest
+    permissions:
+      actions: read
+      contents: read
+      security-events: write
+
+    strategy:
+      fail-fast: false
+      matrix:
+        language: [ 'cpp', 'python' ]
+        # CodeQL supports [ 'cpp', 'csharp', 'go', 'java', 'javascript', 'python', 'ruby' ]
+        # Learn more about CodeQL language support at https://aka.ms/codeql-docs/language-support
+
+    steps:
+    - name: Checkout repository
+      uses: actions/checkout@v3
+
+    # Initializes the CodeQL tools for scanning.
+    - name: Initialize CodeQL
+      uses: github/codeql-action/init@v2
+      with:
+        languages: ${{ matrix.language }}
+        # If you wish to specify custom queries, you can do so here or in a config file.
+        # By default, queries listed here will override any specified in a config file.
+        # Prefix the list here with "+" to use these queries and those in the config file.
+
+        # Details on CodeQL's query packs refer to : https://docs.github.com/en/code-security/code-scanning/automatically-scanning-your-code-for-vulnerabilities-and-errors/configuring-code-scanning#using-queries-in-ql-packs
+        queries: +security-and-quality
+
+    - name: Install apt packages
+      run: |
+            sudo apt update && sudo apt -y install \
+              software-properties-common \
+              qtbase5-dev \
+              libqt5svg5-dev \
+              libqt5websockets5-dev \
+              libqt5opengl5-dev \
+              libqt5x11extras5-dev \
+              libprotoc-dev \
+              libzmq3-dev \
+              liblz4-dev libzstd-dev
+
+    - name: Build Plotjuggler
+      run: |
+          cmake -B build -DCMAKE_INSTALL_PREFIX=install PlotJuggler;
+          cmake --build build --target install
+
+    # ℹ️ Command-line programs to run using the OS shell.
+    # 📚 See https://docs.github.com/en/actions/using-workflows/workflow-syntax-for-github-actions#jobsjob_idstepsrun
+
+    #   If the Autobuild fails above, remove it and uncomment the following three lines.
+    #   modify them (or add more) to build your code if your project, please refer to the EXAMPLE below for guidance.
+
+    # - run: |
+    #   echo "Run, Build Application using script"
+    #   ./location_of_script_within_repo/buildscript.sh
+
+    - name: Perform CodeQL Analysis
+      uses: github/codeql-action/analyze@v2
+      with:
+        category: "/language:${{matrix.language}}"

.github/workflows/macos.yaml

@@ -15,7 +15,7 @@ jobs:
     steps:
       - name: Sync repository
         uses: actions/checkout@v2
-        
+
       - name: Cache Qt
         id: cache-qt
         uses: actions/cache@v1  # not v2!

.github/workflows/pre-commit.yaml

@@ -0,0 +1,14 @@
+name: pre-commit
+
+on:
+  pull_request:
+  push:
+    branches: [main]
+
+jobs:
+  pre-commit:
+    runs-on: ubuntu-latest
+    steps:
+    - uses: actions/checkout@v3
+    - uses: actions/setup-python@v3
+    - uses: pre-commit/[email protected]

.github/workflows/ros1.yaml

@@ -7,11 +7,10 @@ jobs:
     strategy:
       matrix:
         env:
-          - {ROS_DISTRO: melodic, ROS_REPO: main}
           - {ROS_DISTRO: noetic, ROS_REPO: main}
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v3
       - uses: 'ros-industrial/industrial_ci@master'
         env: ${{matrix.env}}
         with:

.github/workflows/ros2-rolling.yaml

@@ -0,0 +1,17 @@
+name: ros2-rolling
+
+on: [push, pull_request]
+
+jobs:
+  industrial_ci:
+    strategy:
+      matrix:
+        env:
+          - {ROS_DISTRO: rolling, ROS_REPO: main}
+    runs-on: ubuntu-latest
+    steps:
+      - uses: actions/checkout@v3
+      - uses: 'ros-industrial/industrial_ci@master'
+        env: ${{matrix.env}}
+        with:
+            package-name: plotjuggler

.github/workflows/ros2.yaml

@@ -7,12 +7,11 @@ jobs:
     strategy:
       matrix:
         env:
-          - {ROS_DISTRO: foxy, ROS_REPO: main}
-          - {ROS_DISTRO: galactic, ROS_REPO: main}
-          - {ROS_DISTRO: rolling, ROS_REPO: main}
+          - {ROS_DISTRO: humble, ROS_REPO: main}
+          - {ROS_DISTRO: iron, ROS_REPO: main}
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/checkout@v1
+      - uses: actions/checkout@v3
       - uses: 'ros-industrial/industrial_ci@master'
         env: ${{matrix.env}}
         with:

.github/workflows/snap.yaml .github/workflows/snap_core20.yaml.github/workflows/snap.yaml renamed to .github/workflows/snap_core20.yaml

@@ -1,36 +1,32 @@
-name: snap
+name: snap_core20
 on:
   push:
     tags:
       - '*'
-    branches:
-      - main
-  pull_request:
-    branches:
-      - main
   workflow_dispatch:
 
 jobs:
   build:
     runs-on: ubuntu-latest
     outputs:
-      snap-file: ${{ steps.build-snap.outputs.snap }}
+      snap-file: ${{ steps.build-snap20.outputs.snap }}
     steps:
     - uses: actions/checkout@v2
       with:
         # full history for latest tag name
         fetch-depth: 0
+    - run: mv snap_core20 snap
     - uses: snapcore/action-build@v1
-      id: build-snap
+      id: build-snap20
 
     # Make sure the snap is installable
     - run: |
-        sudo snap install --dangerous ${{ steps.build-snap.outputs.snap }}
+        sudo snap install --dangerous ${{ steps.build-snap20.outputs.snap }}
 
     - uses: actions/upload-artifact@v3
       with:
-        name: plotjuggler-snap
-        path: ${{ steps.build-snap.outputs.snap }}
+        name: plotjuggler-snap20
+        path: ${{ steps.build-snap20.outputs.snap }}
 
   publish:
     if: github.ref == 'refs/heads/main' || startsWith(github.ref, 'refs/tags/')
@@ -39,7 +35,7 @@ jobs:
     steps:
     - uses: actions/download-artifact@v3
       with:
-        name: plotjuggler-snap
+        name: plotjuggler-snap20
         path: .
     - uses: snapcore/action-publish@v1
       env: