Incorrect TelegramLongPollingCommandBot class constructor implementation causing NPE in CommandRegistry.removeUsernameFromCommandIfNeeded(String command) method

[vikulin]

Incorrect TelegramLongPollingCommandBot class constructor implementation causing NPE in CommandRegistry.removeUsernameFromCommandIfNeeded(String command) method.
See the code line:

TelegramBots/telegrambots-extensions/src/main/java/org/telegram/telegrambots/extensions/bots/commandbot/TelegramLongPollingCommandBot.java

Line 56 in 1a2e7c9

this.commandRegistry = new CommandRegistry(allowCommandsWithUsername, this.getBotUsername());

In time the TelegramLongPollingCommandBot contructor creates the instance method this.getBotUsername() returns null because all fields of implementing class have not been initialized yet. Fields initialization runs after super.TelegramLongPollingCommandBot invocation

Suggested fix: add String botUsername parameter in TelegramLongPollingCommandBot constructor passing to CommandRegistry instance.

[rubenlagus]

@vikulin Feel free to do a pull request with the fix, as long as it is backward compatible, I'm ok with suggested fix

[vikulin]

@rubenlagus , yes, I have created the pull request. See jenkinsci/telegram-notifications-plugin#58

[vikulin]

Also it should be corrected accordingly to my suggestion.

[rubenlagus]

@vikulin That's a different project... not this one

[vikulin]

@rubenlagus , what is the project?

[rubenlagus]

@vikulin Probably the one where you created the issue and are writing now? :)

https://github.com/rubenlagus/TelegramBots

[vikulin]

@rubenlagus ah, yes. There is still only silence...

[rubenlagus]

Should be fixed now