Cut 2.35.0

Author: koic

CHANGELOG.md

@@ -9,6 +9,8 @@
 
 ## master (unreleased)
 
+## 2.35.0 (2026-05-09)
+
 ### Bug fixes
 
 * [#1595](https://github.com/rubocop/rubocop-rails/issues/1595): Fix a false negative for `Rails/I18nLocaleTexts` when using `redirect_back_or_to` with a flash message. ([@55728][])

docs/antora.yml

@@ -2,6 +2,6 @@ name: rubocop-rails
 title: RuboCop Rails
 # We always provide version without patch here (e.g. 1.1),
 # as patch versions should not appear in the docs.
-version: ~
+version: '2.35'
 nav:
   - modules/ROOT/nav.adoc

docs/modules/ROOT/pages/cops_rails.adoc

@@ -3042,7 +3042,7 @@ get :new, **options
 | Name | Default value | Configurable values
 
 | Include
-| `+spec/**/*+`, `+test/**/*+`
+| `+**/spec/**/*+`, `+**/test/**/*+`
 | Array
 |===
 
@@ -3303,7 +3303,7 @@ end
 | Name | Default value | Configurable values
 
 | Include
-| `+spec/**/*.rb+`, `+test/**/*.rb+`
+| `+**/spec/**/*.rb+`, `+**/test/**/*.rb+`
 | Array
 |===
 
@@ -3367,6 +3367,28 @@ class PostsController < ApplicationController
   end
 end
 
+# bad
+class PostsController < ApplicationController
+  def update
+    # ...
+    redirect_back_or_to root_path, alert: "Failed to update!"
+  end
+end
+
+# good
+# config/locales/en.yml
+# en:
+#   posts:
+#     update:
+#       failure: "Failed to update!"
+
+class PostsController < ApplicationController
+  def update
+    # ...
+    redirect_back_or_to root_path, alert: t(".failure")
+  end
+end
+
 # bad
 class UserMailer < ApplicationMailer
   def welcome(user)
@@ -4862,7 +4884,10 @@ a.blank? ? nil : a.foo
 
 # good
 a.presence&.foo
+----
 
+[source,ruby]
+----
 # good
 a.present? ? a[1] : nil
 
@@ -4871,7 +4896,12 @@ a[:key] = value if a.present?
 
 # good
 a.present? ? a > 1 : nil
+
+# good
 a <= 0 if a.present?
+
+# good
+a << "bar" if a.present?
 ----
 
 [#railspresent]
@@ -5480,7 +5510,7 @@ end
 | Name | Default value | Configurable values
 
 | Include
-| `+spec/**/*.rb+`, `+test/**/*.rb+`
+| `+**/spec/**/*.rb+`, `+**/test/**/*.rb+`
 | Array
 |===
 
@@ -5867,12 +5897,15 @@ so you still have to use `JSON.parse(response.body)` there.
 ----
 # bad
 JSON.parse(response.body)
-
-# bad
+Nokogiri::HTML(response.body)
+Nokogiri::HTML4(response.body)
+Nokogiri::HTML5(response.body)
 Nokogiri::HTML.parse(response.body)
-
-# bad
+Nokogiri::HTML4.parse(response.body)
 Nokogiri::HTML5.parse(response.body)
+Nokogiri::HTML::Document.parse(response.body)
+Nokogiri::HTML4::Document.parse(response.body)
+Nokogiri::HTML5::Document.parse(response.body)
 
 # good
 response.parsed_body
@@ -5885,7 +5918,7 @@ response.parsed_body
 | Name | Default value | Configurable values
 
 | Include
-| `+spec/controllers/**/*.rb+`, `+spec/requests/**/*.rb+`, `+test/controllers/**/*.rb+`, `+test/integration/**/*.rb+`
+| `+**/spec/controllers/**/*.rb+`, `+**/spec/requests/**/*.rb+`, `+**/test/controllers/**/*.rb+`, `+**/test/integration/**/*.rb+`
 | Array
 |===
 
@@ -6947,6 +6980,15 @@ NOTE: Requires Rails version 8.0
 
 Enforces the use of `ActionController::Parameters#expect` as a method for strong parameter handling.
 
+In the following cases, `params[:key]` is treated as a key that is expected to be passed from the HTTP client,
+and the cop detects it using the `expect` method.
+
+- Method calls on `params[:key]` without comparison methods
+- Passing `params[:key]` as an argument to finder methods that raise on missing records
+- Strong parameter methods using `require` or `permit`
+
+Other cases are not detected, as they are cases where `params[:key]` may not be passed from the HTTP client.
+
 [#safety-railsstrongparametersexpect]
 === Safety
 
@@ -6960,6 +7002,24 @@ strong parameter conventions.
 
 [source,ruby]
 ----
+# bad
+params[:key].do_something
+
+# good
+params.expect(:key).do_something
+
+# bad
+Model.find(params[:id])
+
+# good
+Model.find(params.expect(:id))
+
+# bad
+Model.find_by!(key: params[:key])
+
+# good
+Model.find_by!(key: params.expect(:key))
+
 # bad
 params.require(:user).permit(:name, :age)
 params.permit(user: [:name, :age]).require(:user)
@@ -7219,7 +7279,7 @@ end
 | Name | Default value | Configurable values
 
 | Include
-| `+spec/**/*.rb+`, `+test/**/*.rb+`
+| `+**/spec/**/*.rb+`, `+**/test/**/*.rb+`
 | Array
 |===
 
@@ -7626,10 +7686,27 @@ More can be added to the `Environments` config parameter.
 # bad
 Rails.env.proudction?
 Rails.env == 'proudction'
+Rails.env != 'proudction'
 
 # good
 Rails.env.production?
 Rails.env == 'production'
+Rails.env != 'production'
+----
+
+[source,ruby]
+----
+# bad
+case Rails.env
+when 'proudction'
+  do_something
+end
+
+# good
+case Rails.env
+when 'production'
+  do_something
+end
 ----
 
 [#configurable-attributes-railsunknownenv]

lib/rubocop/rails/version.rb

@@ -4,7 +4,7 @@ module RuboCop
   module Rails
     # This module holds the RuboCop Rails version information.
     module Version
-      STRING = '2.34.3'
+      STRING = '2.35.0'
 
       def self.document_version
         STRING.match('\d+\.\d+').to_s

relnotes/v2.35.0.md

@@ -0,0 +1,24 @@
+### Bug fixes
+
+* [#1595](https://github.com/rubocop/rubocop-rails/issues/1595): Fix a false negative for `Rails/I18nLocaleTexts` when using `redirect_back_or_to` with a flash message. ([@55728][])
+* [#1587](https://github.com/rubocop/rubocop-rails/pull/1587): Fix false positives for `Rails/Presence` with operator methods like `<<`, `=~`, and others. ([@eugeneius][])
+* [#1586](https://github.com/rubocop/rubocop-rails/pull/1586): Don't add unnecessary parentheses in `Rails/Presence`. ([@eugeneius][])
+* [#1602](https://github.com/rubocop/rubocop-rails/issues/1602): Fix an error in `Rails/SelectMap` when `.select` appears inside a subquery in an argument. ([@koic][])
+* [#1604](https://github.com/rubocop/rubocop-rails/pull/1604): Allow `DatabaseTypeResolvable` to fall back to an `adapter` configuration specified in a `shared` key. ([@codergeek121][])
+* [#1582](https://github.com/rubocop/rubocop-rails/pull/1582): Fix a false negative where `local` was incorrectly treated as a known environment name when using `==` comparison in `Rails/UnknownEnv`. ([@lovro-bikic][])
+
+### Changes
+
+* [#1571](https://github.com/rubocop/rubocop-rails/pull/1571): Add more detection patterns on `Rails/ResponseParsedBody`. ([@r7kamura][])
+* [#1583](https://github.com/rubocop/rubocop-rails/pull/1583): Extend `Rails/StrongParametersExpect` to detect `params[:key]` in method calls and raising finder methods. ([@koic][])
+* [#1584](https://github.com/rubocop/rubocop-rails/pull/1584): Add support for `case` statements to `Rails/UnknownEnv`. ([@lovro-bikic][])
+* [#1592](https://github.com/rubocop/rubocop-rails/pull/1592): Fix false negative for `!=` comparison in `Rails/UnknownEnv`. ([@lovro-bikic][])
+* [#1598](https://github.com/rubocop/rubocop-rails/pull/1598): Use glob patterns compatible with Engine or Packwerk for cops targeting `spec/` and `test/` directories. ([@y-yagi][])
+
+[@55728]: https://github.com/55728
+[@eugeneius]: https://github.com/eugeneius
+[@koic]: https://github.com/koic
+[@codergeek121]: https://github.com/codergeek121
+[@lovro-bikic]: https://github.com/lovro-bikic
+[@r7kamura]: https://github.com/r7kamura
+[@y-yagi]: https://github.com/y-yagi