Merge pull request #1497 from r7kamura/in-where-fix

Fix bugs in `Rails/PluckId` and `Rails/PluckInWhere`

Author: koic

changelog/fix_bugs_in_rails_pluck_id_and_rails_pluck_in_where.md

@@ -0,0 +1 @@
+* [#1497](https://github.com/rubocop/rubocop-rails/pull/1497): Fix bugs in `Rails/PluckId` and `Rails/PluckInWhere`. ([@r7kamura][])

lib/rubocop/cop/mixin/active_record_helper.rb

@@ -106,7 +106,7 @@ def in_where?(node)
         send_node = node.each_ancestor(:call).first
         return false unless send_node
 
-        return true if WHERE_METHODS.include?(send_node.method_name)
+        return true if WHERE_METHODS.include?(send_node.method_name) && send_node.receiver != node
 
         receiver = send_node.receiver
         return false unless receiver&.send_type?

spec/rubocop/cop/rails/pluck_id_spec.rb

@@ -55,4 +55,17 @@ def self.user_ids
       Post.where(user_id: User.pluck(:id))
     RUBY
   end
+
+  context 'when `pluck` is the receiver of `where`' do
+    it 'registers an offense' do
+      expect_offense(<<~RUBY)
+        Post.pluck(:id).where(id: 1..10)
+             ^^^^^^^^^^ Use `ids` instead of `pluck(:id)`.
+      RUBY
+
+      expect_correction(<<~RUBY)
+        Post.ids.where(id: 1..10)
+      RUBY
+    end
+  end
 end

spec/rubocop/cop/rails/pluck_in_where_spec.rb

@@ -132,6 +132,14 @@
         RUBY
       end
     end
+
+    context 'when `pluck` is the receiver of `where`' do
+      it 'does not register an offense' do
+        expect_no_offenses(<<~RUBY)
+          Post.pluck(:id).where(id: 1..10)
+        RUBY
+      end
+    end
   end
 
   context 'EnforcedStyle: aggressive' do