Test edge version of simplecov

Author: bquorning

.github/CONTRIBUTING.md

@@ -65,14 +65,14 @@ E.g. on macOS:
 $ open coverage/index.html
 ```
 
-If you have unreachable lines, you can add `# :nocov` around those lines. The code itself or a comment should explain why the line is unreachable.
+If you have unreachable lines, you can add `# simplecov:disable`/`# simplecov:enable` around those lines. The code itself or a comment should explain why the line is unreachable.
 
 Example:
 
 ```ruby
-# :nocov:
+# simplecov:disable
 raise ArgumentError("Unsupported style :#{style}")
-# :nocov:
+# simplecov:enable
 ```
 
 This can happen for a few reasons, including:

.simplecov

@@ -1,8 +1,7 @@
 # frozen_string_literal: true
 
-SimpleCov.start do
-  enable_coverage :branch
-  minimum_coverage line: 100, branch: 100
-  add_filter '/spec/'
-  add_filter '/vendor/bundle/'
-end
+enable_coverage :branch
+minimum_coverage line: 100, branch: 100
+ignore_branches :implicit_else
+skip '/spec/'
+skip '/vendor/bundle/'

Gemfile

@@ -11,7 +11,7 @@ gem 'rake'
 gem 'rspec', '~> 3.11'
 gem 'rubocop-performance', '~> 1.24'
 gem 'rubocop-rake', '~> 0.7'
-gem 'simplecov', '>= 0.19'
+gem 'simplecov', github: 'simplecov-ruby/simplecov'
 gem 'yard'
 
 # FIXME: Remove when the next prism version is released.

lib/rubocop/cop/rspec/be_nil.rb

@@ -48,10 +48,6 @@ def on_send(node)
             check_be_style(node)
           when :be_nil
             check_be_nil_style(node)
-          else
-            # :nocov:
-            :noop
-            # :nocov:
           end
         end
 

lib/rubocop/cop/rspec/implicit_subject.rb

@@ -107,10 +107,6 @@ def autocorrect(corrector, node)
             corrector.replace(node.location.selector, 'expect(subject).to')
           when :should_not
             corrector.replace(node.location.selector, 'expect(subject).not_to')
-          else
-            # :nocov:
-            :noop
-            # :nocov:
           end
         end
 
@@ -133,10 +129,6 @@ def invalid?(node)
             implicit_subject_in_non_its_and_non_single_line?(node)
           when :single_statement_only
             implicit_subject_in_non_its_and_non_single_statement?(node)
-          else
-            # :nocov:
-            :noop
-            # :nocov:
           end
         end
 

lib/rubocop/cop/rspec/message_spies.rb

@@ -80,10 +80,6 @@ def error_message(receiver)
             MSG_RECEIVE
           when :have_received
             format(MSG_HAVE_RECEIVED, source: receiver.source)
-          else
-            # :nocov:
-            :noop
-            # :nocov:
           end
         end
       end

lib/rubocop/cop/rspec/predicate_matcher.rb

@@ -116,10 +116,6 @@ def true?(to_symbol, matcher)
                      true
                    when :be_falsey, :be_falsy, :a_falsey_value, :a_falsy_value
                      false
-                   else
-                     # :nocov:
-                     :noop
-                     # :nocov:
                    end
           to_symbol == :to ? result : !result
         end
@@ -333,10 +329,6 @@ def on_send(node)
             check_inflected(node)
           when :explicit
             check_explicit(node)
-          else
-            # :nocov:
-            :noop
-            # :nocov:
           end
         end
 

lib/rubocop/cop/rspec/spec_file_path_format.rb

@@ -106,10 +106,6 @@ def inflector
             ActiveSupportInflector
           when 'default'
             DefaultInflector
-          else
-            # :nocov:
-            :noop
-            # :nocov:
           end
         end
 

lib/rubocop/rspec/plugin.rb

@@ -6,7 +6,7 @@ module RuboCop
   module RSpec
     # A plugin that integrates RuboCop RSpec with RuboCop's plugin system.
     class Plugin < LintRoller::Plugin
-      # :nocov:
+      # simplecov:disable
       def about
         LintRoller::About.new(
           name: 'rubocop-rspec',
@@ -15,7 +15,7 @@ def about
           description: 'Code style checking for RSpec files.'
         )
       end
-      # :nocov:
+      # simplecov:enable
 
       def supported?(context)
         context.engine == :rubocop

spec/spec_helper.rb

@@ -3,7 +3,10 @@
 require 'rubocop'
 require 'rubocop/rspec/support'
 
-require 'simplecov' unless ENV['NO_COVERAGE']
+unless ENV['NO_COVERAGE']
+  require 'simplecov'
+  SimpleCov.start
+end
 
 module SpecHelper
   ROOT = Pathname.new(__dir__).parent.freeze