Add item sync specs

A couple notes:

  1. I added a new exception to rubocop to allow for the
     `expect { action_a }.to change { dynamic_attr }` form.
  2. The 2 sec Amazon rate limit delay doesn't apply to tests.

All tests are green and no new rubocop violations are added.

Author: leesharma

.rubocop.yml

@@ -22,3 +22,7 @@ Style/NumericLiterals:
 Style/BlockDelimiters:
   Exclude:
     - spec/**/*
+
+Lint/AmbiguousBlockAssociation:
+  Exclude:
+    - spec/**/*

app/jobs/item_sync_job.rb

@@ -26,7 +26,7 @@ def sync_all!
     # This is done in slices to avoid Amazon rate limits
     Item.all.each_slice(3) do |items|
       items.each { |item| sync! item }
-      sleep 2.seconds
+      sleep 2.seconds unless Rails.env.test?
     end
   end
 

spec/jobs/item_sync_job_spec.rb

@@ -0,0 +1,54 @@
+# frozen_string_literal: true
+
+describe ItemSyncJob do
+  describe '#perform' do
+    context 'for zero items' do
+      it 'runs successfully' do
+        expect { subject.perform }.not_to raise_error
+      end
+    end
+
+    context 'for one item', :external do
+      let!(:corgi) { create(:item, asin: 'corgi_asin') }
+
+      context 'when an item is unchanged' do
+        before { subject.perform }
+
+        it 'keeps the original item' do
+          expect { subject.perform }.not_to change { corgi.reload.attributes }
+        end
+      end
+
+      context 'when an item is changed' do
+        it 'updates the item name' do
+          expect { subject.perform }.to change { corgi.reload.name }
+        end
+
+        it 'updates the item price' do
+          expect { subject.perform }.to change { corgi.reload.price_cents }
+        end
+
+        it 'updates the item url' do
+          expect { subject.perform }.to change { corgi.reload.amazon_url }
+        end
+
+        it 'updates the item image url' do
+          expect { subject.perform }.to change { corgi.reload.image_url }
+        end
+      end
+    end
+
+    context 'for multiple items', :external do
+      let!(:item_1) { create(:item, asin: 'corgi_asin') }
+      let!(:item_2) { create(:item, asin: 'corgi_asin2') }
+
+      it 'updates the first item' do
+        expect { subject.perform }.to change { item_1.reload.attributes }
+      end
+
+      it 'updates the second item' do
+        expect { subject.perform }.to change { item_2.reload.attributes }
+      end
+    end
+  end
+end

spec/support/webmock.rb

@@ -7,17 +7,25 @@
 RSpec.configure do |config|
   config.before(:each, :external) do
     # Item Search
+
     search_response = file_fixture('amazon_corgi_search_response.xml').read
     stub_request(:get, 'webservices.amazon.com/onca/xml')
       .with(query: hash_including('Operation' => 'ItemSearch',
                                   'Keywords'  => 'corgi'))
       .to_return(body: search_response)
 
     # Item Lookup
+
     lookup_response = file_fixture('amazon_corgi_lookup_response.xml').read
+
+    stub_request(:get, 'webservices.amazon.com/onca/xml')
+      .with(query: hash_including('Operation' => 'ItemLookup',
+                                  'ItemId'    => 'corgi_asin'))
+      .to_return(body: lookup_response)
+
     stub_request(:get, 'webservices.amazon.com/onca/xml')
       .with(query: hash_including('Operation' => 'ItemLookup',
-                                  'ItemId' => 'corgi_asin'))
+                                  'ItemId'    => 'corgi_asin2'))
       .to_return(body: lookup_response)
   end
 end