Skip to content
This repository was archived by the owner on Apr 14, 2021. It is now read-only.

Commit 35781bb

Browse files
bundlerbotsegiddins
andcommitted
Merge #6112
6112: Add a spec for installing git deps after packaging without git r=deivid-rodriguez a=segiddins ### What was the end-user problem that led to this PR? The problem was v1.15 seemed to break installing without git when the git deps had already been packaged (see #6066). ### What was your diagnosis of the problem? My diagnosis was we actually seemed to have fixed this for 1.16. ### What is your fix for the problem, implemented in this PR? My fix adds a test to ensure we won't regress. Co-authored-by: Samuel Giddins <[email protected]>
2 parents c808184 + 65351c5 commit 35781bb

File tree

1 file changed

+17
-0
lines changed

1 file changed

+17
-0
lines changed

spec/cache/git_spec.rb

+17
Original file line numberDiff line numberDiff line change
@@ -220,5 +220,22 @@
220220
gemspec = bundled_app("vendor/cache/foo-1.0-#{ref}/foo.gemspec").read
221221
expect(gemspec).to_not match("`echo bob`")
222222
end
223+
224+
it "can install after #{cmd} with git not installed" do
225+
build_git "foo"
226+
227+
gemfile <<-G
228+
gem "foo", :git => '#{lib_path("foo-1.0")}'
229+
G
230+
bundle! "config set cache_all true"
231+
bundle! cmd, "all-platforms" => true, :install => false, :path => "./vendor/cache"
232+
233+
simulate_new_machine
234+
with_path_as "" do
235+
bundle! "config set deployment true"
236+
bundle! :install, :local => true
237+
expect(the_bundle).to include_gem "foo 1.0"
238+
end
239+
end
223240
end
224241
end

0 commit comments

Comments
 (0)