Skip to content

Commit c2fe954

Browse files
authored
feat: remove duplicate ad-revenue key (#81)
* feat(appsflyer): remove duplicate kAppsFlyerAdRevenueAdType key from promotion events Remove redundant kAppsFlyerAdRevenueAdType mapping from ECommPromotionViewed and ECommPromotionClicked handlers, keeping only the string literal "af_adrev_ad_type" which matches the original AFEventParamAdRevenueAdType behavior. Scanned-by: gitleaks 8.29.0 * fix(ci): use app token for release branch deletion The delete-merged-action step used secrets.GITHUB_TOKEN which is restricted to read-only by job-level permissions. Replace with the app token that already has contents:write permission. Scanned-by: gitleaks 8.29.0
1 parent f49c2ee commit c2fe954

2 files changed

Lines changed: 1 addition & 3 deletions

File tree

.github/workflows/publish-new-release.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -62,4 +62,4 @@ jobs:
6262
with:
6363
branches: 'release/*'
6464
env:
65-
GITHUB_TOKEN: ${{ secrets.GITHUB_TOKEN }}
65+
GITHUB_TOKEN: ${{ steps.generate-token.outputs.token }}

Rudder-Appsflyer/Classes/RudderAppsflyerIntegration.m

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -91,7 +91,6 @@ - (void) processRudderEvent: (nonnull RSMessage *) message {
9191
afEventName = AFEventAdView;
9292
if(properties[CREATIVE]) {
9393
[afProperties setValue:properties[CREATIVE] forKey:@"af_adrev_ad_type"];
94-
[afProperties setValue:properties[CREATIVE] forKey:kAppsFlyerAdRevenueAdType];
9594
}
9695
if(properties[KeyCurrency]) {
9796
[afProperties setValue:properties[KeyCurrency] forKey:AFEventParamCurrency];
@@ -101,7 +100,6 @@ - (void) processRudderEvent: (nonnull RSMessage *) message {
101100
afEventName = AFEventAdClick;
102101
if(properties[CREATIVE]) {
103102
[afProperties setValue:properties[CREATIVE] forKey:@"af_adrev_ad_type"];
104-
[afProperties setValue:properties[CREATIVE] forKey:kAppsFlyerAdRevenueAdType];
105103
}
106104
if(properties[KeyCurrency]) {
107105
[afProperties setValue:properties[KeyCurrency] forKey:AFEventParamCurrency];

0 commit comments

Comments
 (0)