Skip to content

Commit 50d50f0

Browse files
authored
fix: support Facebook SDK 18 and fix $FacebookSDKVersion override (#57)
* fix: support Facebook SDK 18 and fix $FacebookSDKVersion override - widen default FBSDKCoreKit constraint from `~> 17.0.2` to `>= 17.0.2, < 19.0` to allow Facebook SDK 18.x - fix `$FacebookSDKVersion` override crashing pod install (missing `$` referenced undefined constant Pod::FacebookSDKVersion) - splat the version via `*Array(...)` so both string overrides and the default range are passed to s.dependency Scanned-by: gitleaks 8.29.0 * chore: format default Facebook SDK version log for array constraint Join the version requirement array so the install log prints `>= 17.0.2, < 19.0` instead of the raw Ruby array literal. Scanned-by: gitleaks 8.29.0 * fix: ignore nil or empty $FacebookSDKVersion override Guard the override on a non-empty value so a nil/blank $FacebookSDKVersion (e.g. from a missing env var) falls back to the default `>= 17.0.2, < 19.0` range instead of dropping the version cap. Scanned-by: gitleaks 8.29.0
1 parent f33902e commit 50d50f0

1 file changed

Lines changed: 5 additions & 5 deletions

File tree

Rudder-Facebook.podspec

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ require 'json'
22

33
package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
44

5-
facebook_sdk_version = '~> 17.0.2'
5+
facebook_sdk_version = ['>= 17.0.2', '< 19.0']
66
rudder_sdk_version = '~> 1.12'
77
deployment_target = '12.0'
88
facebook_app_events = 'FBSDKCoreKit'
@@ -25,11 +25,11 @@ Pod::Spec.new do |s|
2525
s.source_files = 'Rudder-Facebook/Classes/**/*'
2626
s.ios.deployment_target = deployment_target
2727

28-
if defined?($FacebookSDKVersion)
28+
if defined?($FacebookSDKVersion) && !$FacebookSDKVersion.to_s.empty?
2929
facebook_sdk_version = $FacebookSDKVersion
30-
Pod::UI.puts "#{s.name}: Using user specified Facebook SDK version '#{FacebookSDKVersion}'"
30+
Pod::UI.puts "#{s.name}: Using user specified Facebook SDK version '#{$FacebookSDKVersion}'"
3131
else
32-
Pod::UI.puts "#{s.name}: Using default facebook SDK version '#{facebook_sdk_version}'"
32+
Pod::UI.puts "#{s.name}: Using default facebook SDK version '#{Array(facebook_sdk_version).join(', ')}'"
3333
end
3434

3535
if defined?($RudderSDKVersion)
@@ -40,5 +40,5 @@ Pod::Spec.new do |s|
4040
end
4141

4242
s.dependency 'Rudder', rudder_sdk_version
43-
s.dependency facebook_app_events, facebook_sdk_version
43+
s.dependency facebook_app_events, *Array(facebook_sdk_version)
4444
end

0 commit comments

Comments
 (0)