Skip to content

Commit cfa45d5

Browse files
committed
fix: support Facebook SDK 18 and fix $FacebookSDKVersion override
- widen default FBSDKCoreKit constraint from `~> 17.0.2` to `>= 17.0.2, < 19.0` to allow Facebook SDK 18.x - fix `$FacebookSDKVersion` override crashing pod install (missing `$` referenced undefined constant Pod::FacebookSDKVersion) - splat the version via `*Array(...)` so both string overrides and the default range are passed to s.dependency Scanned-by: gitleaks 8.29.0
1 parent f33902e commit cfa45d5

1 file changed

Lines changed: 3 additions & 3 deletions

File tree

Rudder-Facebook.podspec

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@ require 'json'
22

33
package = JSON.parse(File.read(File.join(__dir__, 'package.json')))
44

5-
facebook_sdk_version = '~> 17.0.2'
5+
facebook_sdk_version = ['>= 17.0.2', '< 19.0']
66
rudder_sdk_version = '~> 1.12'
77
deployment_target = '12.0'
88
facebook_app_events = 'FBSDKCoreKit'
@@ -27,7 +27,7 @@ Pod::Spec.new do |s|
2727

2828
if defined?($FacebookSDKVersion)
2929
facebook_sdk_version = $FacebookSDKVersion
30-
Pod::UI.puts "#{s.name}: Using user specified Facebook SDK version '#{FacebookSDKVersion}'"
30+
Pod::UI.puts "#{s.name}: Using user specified Facebook SDK version '#{$FacebookSDKVersion}'"
3131
else
3232
Pod::UI.puts "#{s.name}: Using default facebook SDK version '#{facebook_sdk_version}'"
3333
end
@@ -40,5 +40,5 @@ Pod::Spec.new do |s|
4040
end
4141

4242
s.dependency 'Rudder', rudder_sdk_version
43-
s.dependency facebook_app_events, facebook_sdk_version
43+
s.dependency facebook_app_events, *Array(facebook_sdk_version)
4444
end

0 commit comments

Comments
 (0)