fix: common js function to validate url

Author: maheshkutty

package-lock.json

@@ -125,17 +125,7 @@ describe('GoogleAds init tests', () => {
         {},
         destinationInfo,
       );
-    }).toThrow('[GoogleAds]: Invalid sdkBaseUrl: "not-a-valid-url"');
-  });
-
-  test('throws an error when sdkBaseUrl contains ngrok domain', () => {
-    expect(() => {
-      new GoogleAds(
-        { conversionID: mockConversionId, sdkBaseUrl: 'https://abc.ngrok.io' },
-        {},
-        destinationInfo,
-      );
-    }).toThrow('[GoogleAds]: Invalid sdkBaseUrl: "https://abc.ngrok.io"');
+    }).toThrow('Invalid sdkBaseUrl: "not-a-valid-url"');
   });
 
   test('uses default GTM domain when sdkBaseUrl is undefined', () => {

packages/analytics-js-integrations/__tests__/integrations/GoogleAds/browser.test.js

@@ -83,6 +83,7 @@
     "on-body": "0.0.1",
     "component-each": "0.2.6",
     "@ndhoule/extend": "2.0.0",
+    "@rudderstack/analytics-js-common": "*",
     "@lukeed/uuid": "2.0.1",
     "get-value": "4.0.1",
     "ramda": "0.32.0"

packages/analytics-js-integrations/package.json

@@ -18,7 +18,8 @@ import {
 import { loadNativeSdk } from './nativeSdkLoader';
 
 import { prepareParamsAndEventName } from '../GA4/utils';
-import { getValueOrDefault, removeTrailingSlashes, isValidURL } from '../../utils/utils';
+import { getValueOrDefault, removeTrailingSlashes } from '../../utils/utils';
+import { isValidURL } from '@rudderstack/analytics-js-common/utilities/url';
 
 const logger = new Logger(DISPLAY_NAME);
 
@@ -50,12 +51,8 @@ class GoogleAds {
     this.v2 = getValueOrDefault(config.v2, true);
     this.allowIdentify = config.allowIdentify ?? false;
     const sanitizedSdkBaseUrl = removeTrailingSlashes(config.sdkBaseUrl);
-    if (sanitizedSdkBaseUrl) {
-      const SDK_BASE_URL_PATTERN =
-        "(^\\{\\{.*\\|\\|(.*)\\}\\}$)|(^env[.].+)|(?!.*\\.ngrok\\.io)^(?:http(s)?:\\/\\/)?[\\w.-]+(?:\\.[\\w.-]+)+[\\w\\-._~:/?#[\\]@!\\$&'\\(\\)\\*\\+,;=.]*|^$";
-      if (!isValidURL(sanitizedSdkBaseUrl, SDK_BASE_URL_PATTERN)) {
-        throw new Error(`[GoogleAds]: Invalid sdkBaseUrl: "${sanitizedSdkBaseUrl}"`);
-      }
+    if (sanitizedSdkBaseUrl && !isValidURL(sanitizedSdkBaseUrl)) {
+      throw new Error(`Invalid sdkBaseUrl: "${sanitizedSdkBaseUrl}"`);
     }
     this.sdkBaseUrl = sanitizedSdkBaseUrl || 'https://www.googletagmanager.com';
     this.name = NAME;

packages/analytics-js-integrations/src/integrations/GoogleAds/browser.js

@@ -35,30 +35,6 @@ function removeTrailingSlashes(inURL) {
   return inURL?.endsWith('/') ? inURL.replace(/\/+$/, '') : inURL;
 }
 
-const URL_PATTERN = new RegExp(
-  '^(https?:\\/\\/)' +
-    '(' +
-    '((([a-zA-Z\\d]([a-zA-Z\\d-]*[a-zA-Z\\d])*)\\.)+[a-zA-Z]{2,}|' +
-    'localhost|' +
-    '((25[0-5]|2[0-4][0-9]|[0-1]?[0-9]?[0-9]?)\\.){3}' +
-    '(25[0-5]|2[0-4][0-9]|[0-1]?[0-9]?[0-9]?))' +
-    ')' +
-    '(\\:\\d+)?' +
-    '(\\/[-a-zA-Z\\d%_.~+]*)*' +
-    '(\\?[;&a-zA-Z\\d%_.~+=-]*)?' +
-    '(\\#[-a-zA-Z\\d_]*)?$',
-);
-
-function isValidURL(url, pattern) {
-  if (typeof url !== 'string') {
-    return false;
-  }
-  if (typeof pattern === 'string' && !new RegExp(pattern).test(url)) {
-    return false;
-  }
-  return URL_PATTERN.test(url);
-}
-
 /**
  *
  * Utility function for UUID generation
@@ -634,7 +610,6 @@ export {
   isDefinedAndNotNull,
   getDataFromSource,
   removeTrailingSlashes,
-  isValidURL,
   constructPayload,
   isEmptyObject,
   getValueOrDefault,