Skip to content

Commit f015422

Browse files
committed
chore: clean up env url issues
1 parent 34d4689 commit f015422

2 files changed

Lines changed: 4 additions & 4 deletions

File tree

packages/analytics-js/public/index.html

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -176,13 +176,13 @@
176176
const envDestSDKBaseURL = '__DEST_SDK_BASE_URL__';
177177
// This is to avoid the build process from replacing the placeholder with the actual value
178178
const envDestSDKBaseURLPlaceHolder = '__' + 'DEST_SDK_BASE_URL' + '__';
179-
if (envDestSDKBaseURL !== '' && envDestSDKBaseURL !== 'undefined' && envDestSDKBaseURL !== envDestSDKBaseURLPlaceHolder) {
179+
if (envDestSDKBaseURL !== '' && envDestSDKBaseURL !== 'undefined/' && envDestSDKBaseURL !== envDestSDKBaseURLPlaceHolder) {
180180
loadOptions.destSDKBaseURL = envDestSDKBaseURL + window.rudderAnalyticsBuildType + '/js-integrations';
181181
}
182182
const envPluginsSDKBaseURL = '__PLUGINS_BASE_URL__';
183183
// This is to avoid the build process from replacing the placeholder with the actual value
184184
const envPluginsSDKBaseURLPlaceHolder = '__' + 'PLUGINS_BASE_URL' + '__';
185-
if (envPluginsSDKBaseURL !== '' && envPluginsSDKBaseURL !== 'undefined' && envPluginsSDKBaseURL !== envPluginsSDKBaseURLPlaceHolder) {
185+
if (envPluginsSDKBaseURL !== '' && envPluginsSDKBaseURL !== 'undefined/' && envPluginsSDKBaseURL !== envPluginsSDKBaseURLPlaceHolder) {
186186
loadOptions.pluginsSDKBaseURL = envPluginsSDKBaseURL + window.rudderAnalyticsBuildType + '/plugins';
187187
}
188188
const envConfigUrl = '__CONFIG_SERVER_HOST__';

packages/analytics-js/rollup.config.mjs

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -35,9 +35,9 @@ const sourceMapType =
3535
process.env.PROD_DEBUG === 'inline' ? 'inline' : process.env.PROD_DEBUG === 'true';
3636
const cdnPath = isDynamicCustomBuild ? `dynamicCdnBundle` : `cdn`;
3737
let remotePluginsBasePath =
38-
process.env.REMOTE_MODULES_BASE_PATH;
38+
process.env.REMOTE_MODULES_BASE_PATH ?? `${baseCdnUrl}/v3`;
3939
remotePluginsBasePath = remotePluginsBasePath?.endsWith('/') ? remotePluginsBasePath : `${remotePluginsBasePath}/`;
40-
let destSDKBaseURL = process.env.DEST_SDK_BASE_URL;
40+
let destSDKBaseURL = process.env.DEST_SDK_BASE_URL ?? `${baseCdnUrl}/v3`;
4141
destSDKBaseURL = destSDKBaseURL?.endsWith('/') ? destSDKBaseURL : `${destSDKBaseURL}/`;
4242
const outDirNpmRoot = `dist/npm`;
4343
const outDirCDNRoot = `dist/${cdnPath}`;

0 commit comments

Comments
 (0)