chore: fix test cases and lint issues

Author: ItsSudip

regulation-worker/cmd/main.go

@@ -152,7 +152,7 @@ func createHTTPClient(conf *config.Config, httpTimeout time.Duration) *http.Clie
 	}
 	return oauthv2http.NewOAuthHttpClient(
 		cli,
-		common.RudderFlow(common.RudderFlowDelete),
+		common.RudderFlowDelete,
 		&cache, backendconfig.DefaultBackendConfig,
 		api.GetAuthErrorCategoryFromResponse, &optionalArgs,
 	)

regulation-worker/internal/delete/api/api.go

@@ -40,10 +40,6 @@ type APIManager struct {
 	TransformerFeaturesService   transformer.FeaturesService
 }
 
-type oauthDetail struct {
-	id string
-}
-
 func GetAuthErrorCategoryFromResponse(bodyBytes []byte) (string, error) {
 	var jobResp []JobRespSchema
 	if err := jsonrs.Unmarshal(bodyBytes, &jobResp); err != nil {

regulation-worker/internal/delete/api/api_test.go

@@ -829,7 +829,7 @@ func TestOAuth(t *testing.T) {
 				Locker:    oauthLock,
 			}
 			cli = oauthv2_http.NewOAuthHttpClient(
-				cli, common.RudderFlow(common.RudderFlowDelete),
+				cli, common.RudderFlowDelete,
 				&cache, mockBackendConfig,
 				api.GetAuthErrorCategoryFromResponse, &optionalArgs,
 			)
@@ -843,8 +843,7 @@ func TestOAuth(t *testing.T) {
 			status := api.Delete(ctx, tt.job, tt.dest)
 			require.Equal(t, tt.expectedDeleteStatus.Status, status.Status)
 			if tt.expectedDeleteStatus.Status != model.JobStatusComplete {
-				exp := tt.expectedDeleteStatus.Error.Error()
-				exp = tt.expectedDeleteStatus_OAuthV2.Error.Error()
+				exp := tt.expectedDeleteStatus_OAuthV2.Error.Error()
 				jobError := strings.Replace(exp, "__cfgBE_server__", cfgBeSrv.URL, 1)
 
 				require.Contains(t, strings.ToLower(status.Error.Error()), strings.ToLower(jobError))

router/transformer/transformer.go

@@ -522,7 +522,9 @@ func (trans *handle) ProxyRequest(ctx context.Context, proxyReqParams *ProxyRequ
 			transResp.routerJobResponseBodys[metadata.JobID] = transportResponse.InterceptorResponse.Response
 		}
 	}
-	respData = []byte(transportResponse.InterceptorResponse.Response)
+	if transportResponse.InterceptorResponse.Response != "" {
+		respData = []byte(transportResponse.InterceptorResponse.Response)
+	}
 
 	trans.stats.NewTaggedStat("transformer_client_response_total_events", stats.CountType, labels).Count(len(transResp.routerJobResponseCodes))
 

router/types.go

@@ -1,7 +1,6 @@
 package router
 
 import (
-	"context"
 	"encoding/json"
 	"sync"
 	"time"
@@ -22,17 +21,6 @@ type workerJobStatus struct {
 	statTags   map[string]string
 	parameters routerutils.JobParameters
 }
-
-type HandleDestOAuthRespParams struct {
-	ctx            context.Context
-	destinationJob types.DestinationJobT
-	workerID       int
-	trRespStCd     int
-	trRespBody     string
-	secret         json.RawMessage
-	contentType    string
-}
-
 type Diagnostic struct {
 	diagnosisTicker    *time.Ticker
 	requestsMetricLock sync.RWMutex