Skip to content

Commit b5f9ce5

Browse files
committed
fixup! chore: plugging in jobsdb.NewDistinctValuesCache
1 parent 815ecbb commit b5f9ce5

File tree

3 files changed

+2
-22
lines changed

3 files changed

+2
-22
lines changed

app/cluster/integration_test.go

+1-3
Original file line numberDiff line numberDiff line change
@@ -107,8 +107,6 @@ func TestDynamicClusterManager(t *testing.T) {
107107
defer gwDB.TearDown()
108108
eschDB := jobsdb.NewForReadWrite("esch", jobsdb.WithStats(stats.NOP))
109109
defer eschDB.TearDown()
110-
archiveDB := jobsdb.NewForReadWrite("archive", jobsdb.WithStats(stats.NOP))
111-
defer archiveDB.TearDown()
112110
rtDB := jobsdb.NewForReadWrite("rt", jobsdb.WithStats(stats.NOP))
113111
defer rtDB.TearDown()
114112
brtDB := jobsdb.NewForReadWrite("batch_rt", jobsdb.WithStats(stats.NOP))
@@ -199,7 +197,7 @@ func TestDynamicClusterManager(t *testing.T) {
199197
ArchivalDB: archDB,
200198
SchemaForwarder: schemaForwarder,
201199
Archiver: arc.New(
202-
archiveDB,
200+
archDB,
203201
nil,
204202
config.Default,
205203
stats.Default,

jobsdb/jobsdb.go

+1-4
Original file line numberDiff line numberDiff line change
@@ -1959,10 +1959,6 @@ func (jd *Handle) getDistinctValuesPerDataset(
19591959
dsList []string,
19601960
param ParameterName,
19611961
) (map[string][]string, error) {
1962-
if len(dsList) == 0 {
1963-
return nil, nil
1964-
}
1965-
19661962
var queries []string
19671963
for _, ds := range dsList {
19681964
queries = append(queries, fmt.Sprintf(parametersWithoutCustomval, param.string(), ds))
@@ -2001,6 +1997,7 @@ func (jd *Handle) GetDistinctParameterValues(ctx context.Context, parameter Para
20011997
return nil, fmt.Errorf("could not acquire a dslist read lock: %w", ctx.Err())
20021998
}
20031999
dsList := jd.getDSList()
2000+
jd.logger.Info(dsList)
20042001
jd.dsListLock.RUnlock()
20052002
values, err := jd.distinctValuesCache.GetDistinctValues(
20062003
parameter.string(),

mocks/jobsdb/mock_jobsdb.go

-15
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

0 commit comments

Comments
 (0)