fix: misc issues and handle backward compatibility

Author: saikumarrs

processor/consent.go

@@ -13,10 +13,17 @@ import (
 )
 
 type ConsentManagementInfo struct {
-	AllowedConsentIDs  []string `json:"allowedConsentIds"`
-	DeniedConsentIDs   []string `json:"deniedConsentIds"`
-	Provider           string   `json:"provider"`
-	ResolutionStrategy string   `json:"resolutionStrategy"`
+	AllowedConsentIDs  []string
+	DeniedConsentIDs   []string
+	Provider           string
+	ResolutionStrategy string
+}
+
+type EventConsentManagementInfo struct {
+	AllowedConsentIDs  interface{} `json:"allowedConsentIds"`
+	DeniedConsentIDs   []string    `json:"deniedConsentIds"`
+	Provider           string      `json:"provider"`
+	ResolutionStrategy string      `json:"resolutionStrategy"`
 }
 
 type GenericConsentManagementProviderData struct {
@@ -220,28 +227,56 @@ func getGenericConsentManagementData(dest *backendconfig.DestinationT) (ConsentP
 }
 
 func getConsentManagementInfo(event types.SingularEventT) (ConsentManagementInfo, error) {
+	consentManagementInfoFromEvent := EventConsentManagementInfo{}
 	consentManagementInfo := ConsentManagementInfo{}
 	if consentManagement, ok := misc.MapLookup(event, "context", "consentManagement").(map[string]interface{}); ok {
 		consentManagementObjBytes, mErr := jsonrs.Marshal(consentManagement)
 		if mErr != nil {
 			return consentManagementInfo, fmt.Errorf("error marshalling consentManagement: %v", mErr)
 		}
 
-		unmErr := jsonrs.Unmarshal(consentManagementObjBytes, &consentManagementInfo)
+		unmErr := jsonrs.Unmarshal(consentManagementObjBytes, &consentManagementInfoFromEvent)
 		if unmErr != nil {
 			return consentManagementInfo, fmt.Errorf("error unmarshalling consentManagementInfo: %v", unmErr)
 		}
 
+		consentManagementInfo.DeniedConsentIDs = consentManagementInfoFromEvent.DeniedConsentIDs
+		consentManagementInfo.Provider = consentManagementInfoFromEvent.Provider
+		consentManagementInfo.ResolutionStrategy = consentManagementInfoFromEvent.ResolutionStrategy
+
+		// This is to support really old version of the JS SDK v3 that sent this data as an object
+		// for OneTrust provider.
+		// Handle AllowedConsentIDs based on its type (array or map)
+		switch val := consentManagementInfoFromEvent.AllowedConsentIDs.(type) {
+		case []interface{}:
+			// Convert []interface{} to []string
+			consentManagementInfo.AllowedConsentIDs = make([]string, 0, len(val))
+			for _, v := range val {
+				if strVal, ok := v.(string); ok {
+					consentManagementInfo.AllowedConsentIDs = append(consentManagementInfo.AllowedConsentIDs, strVal)
+				}
+			}
+		case []string:
+			// Already a string array
+			consentManagementInfo.AllowedConsentIDs = val
+		case map[string]interface{}:
+			// Use keys from the map (legacy OneTrust format)
+			consentManagementInfo.AllowedConsentIDs = lo.Keys(val)
+		default:
+			consentManagementInfo.AllowedConsentIDs = []string{}
+		}
+
 		// Ideally, the clean up and filter is not needed for standard providers
 		// but useful for custom providers where users send this data directly
 		// to the SDKs.
-		cleanupPredicate := func(consent string, _ int) (string, bool) {
-			return strings.TrimSpace(consent), consent != ""
+		sanitizePredicate := func(consent string, _ int) string {
+			return strings.TrimSpace(consent)
 		}
 
-		consentManagementInfo.AllowedConsentIDs = lo.FilterMap(consentManagementInfo.AllowedConsentIDs, cleanupPredicate)
-		consentManagementInfo.DeniedConsentIDs = lo.FilterMap(consentManagementInfo.DeniedConsentIDs, cleanupPredicate)
+		consentManagementInfo.AllowedConsentIDs = lo.Map(consentManagementInfo.AllowedConsentIDs, sanitizePredicate)
+		consentManagementInfo.DeniedConsentIDs = lo.Map(consentManagementInfo.DeniedConsentIDs, sanitizePredicate)
 
+		// Filter out empty values
 		filterPredicate := func(consent string, _ int) (string, bool) {
 			return consent, consent != ""
 		}

processor/consent_test.go

@@ -2517,7 +2517,7 @@ func TestGetConsentManagementInfo(t *testing.T) {
 							"consent category 2",
 						},
 						"deniedConsentIds": []string{
-							"consent category 3",
+							"   consent category 3   ",
 							"",
 							"consent category 4",
 							"",
@@ -2552,9 +2552,9 @@ func TestGetConsentManagementInfo(t *testing.T) {
 				"context": map[string]interface{}{
 					"consentManagement": map[string]interface{}{
 						"deniedConsentIds": []string{
-							"consent category 3",
-							"",
-							"consent category 4",
+							"consent category 3 ",
+							"   ",
+							" consent category 4",
 							"",
 						},
 					},
@@ -2570,6 +2570,43 @@ func TestGetConsentManagementInfo(t *testing.T) {
 				ResolutionStrategy: "",
 			},
 		},
+		{
+			description: "should return consent management info when consent management data is sent from older SDKs with allowed consent IDs as an object",
+			input: types.SingularEventT{
+				"anonymousId": "123",
+				"type":        "track",
+				"event":       "test",
+				"properties": map[string]interface{}{
+					"category": "test",
+				},
+				"context": map[string]interface{}{
+					"consentManagement": map[string]interface{}{
+						"allowedConsentIds": map[string]interface{}{
+							"C0": "consent category 1",
+							"C1": "consent category 2",
+						},
+						"deniedConsentIds": []string{
+							"consent category 3 ",
+							"   ",
+							" consent category 4",
+							"",
+						},
+					},
+				},
+			},
+			expected: ConsentManagementInfo{
+				Provider: "",
+				AllowedConsentIDs: []string{
+					"C0",
+					"C1",
+				},
+				DeniedConsentIDs: []string{
+					"consent category 3",
+					"consent category 4",
+				},
+				ResolutionStrategy: "",
+			},
+		},
 	}
 
 	for _, testCase := range testCases {

processor/processor_test.go

@@ -3653,7 +3653,7 @@ var _ = Describe("Processor", Ordered, func() {
 						"destination-definition-name-enabled",
 					),
 				)),
-			).To(Equal(8)) // all except D13
+			).To(Equal(6)) // all except D6, D13, and D14
 
 			Expect(processor.isDestinationAvailable(eventWithDeniedConsentsGCM, SourceIDGCM, "")).To(BeTrue())
 			Expect(