chore: capture profile data from integration test

🔒 Scanned for secrets using gitleaks 8.30.0

Author: atzoum

.gitignore

@@ -10,7 +10,7 @@ workspaceConfig.json
 imports/enterprise.go
 *.coverprofile
 junit*.xml
-**/profile.out
+**/*profile.out
 **/*.test
 .idea/*
 build/regulation-worker

Makefile

@@ -65,9 +65,9 @@ test-teardown:
     	echo "Tests passed, tearing down..." ;\
 		rm -f $(TESTFILE) ;\
 		echo "mode: atomic" > coverage.txt ;\
-		find . -name "profile.out" | while read file; do grep -v 'mode: atomic' $${file} >> coverage.txt; rm -f $${file}; done ;\
+		find . -name "*profile.out" | while read file; do grep -Ev 'mode: atomic|mode: set' $${file} >> coverage.txt; rm -f $${file}; done ;\
 	else \
-    	rm -f coverage.txt coverage.html ; find . -name "profile.out" | xargs rm -f ;\
+    	rm -f coverage.txt coverage.html ; find . -name "*profile.out" | xargs rm -f ;\
 		echo "Tests failed :-(" ;\
 		exit 1 ;\
 	fi

integration_test/partitionmigration/partitionmigration_embedded_test.go

@@ -161,7 +161,7 @@ func TestPartitionMigrationEmbeddedMode(t *testing.T) {
 	rsBinaryPath := filepath.Join(t.TempDir(), "rudder-server-binary")
 	buildRudderServerBinary(t, rsBinaryPath)
 	node0Name := "node-0"
-	startRudderServer(ctx, g, node0Name, rsBinaryPath, lo.Assign(commonEnv, map[string]string{
+	startRudderServer(t, ctx, g, node0Name, rsBinaryPath, lo.Assign(commonEnv, map[string]string{
 		"PROCESSOR_INDEX":                     "0",
 		"HOSTNAME":                            node0Name,
 		"INSTANCE_ID":                         node0Name,
@@ -182,7 +182,7 @@ func TestPartitionMigrationEmbeddedMode(t *testing.T) {
 	)
 
 	node1Name := "node-1"
-	startRudderServer(ctx, g, node1Name, rsBinaryPath, lo.Assign(commonEnv, map[string]string{
+	startRudderServer(t, ctx, g, node1Name, rsBinaryPath, lo.Assign(commonEnv, map[string]string{
 		"PROCESSOR_INDEX":                     "1",
 		"HOSTNAME":                            node1Name,
 		"INSTANCE_ID":                         node1Name,

integration_test/partitionmigration/rudderserver_test.go

@@ -17,7 +17,7 @@ import (
 // buildRudderServerBinary builds the rudder-server binary and returns its path.
 func buildRudderServerBinary(t *testing.T, binaryPath string) {
 	name := "testbinary"
-	buildCmd := exec.Command("go", "build", "-o", binaryPath, "../../main.go")
+	buildCmd := exec.Command("go", "build", "-cover", "-o", binaryPath, "../../main.go")
 	buildCmd.Stderr = os.Stderr
 	buildCmd.Stdout = os.Stdout
 	if err := buildCmd.Run(); err != nil {
@@ -26,17 +26,31 @@ func buildRudderServerBinary(t *testing.T, binaryPath string) {
 }
 
 // startRudderServer starts a rudder-server process with the given environment configuration in a separate goroutine managed by the provided errgroup.Group.
-func startRudderServer(ctx context.Context, g *errgroup.Group, name, binaryPath string, configs map[string]string) {
+// It sends SIGTERM when the context is cancelled to allow graceful shutdown and proper coverage data collection.
+func startRudderServer(t *testing.T, ctx context.Context, g *errgroup.Group, name, binaryPath string, configs map[string]string) {
+	coverDir := t.TempDir()
+	configs["GOCOVERDIR"] = coverDir
+	// Don't use exec.CommandContext - it sends SIGKILL on context cancellation,
+	// which prevents the process from writing coverage data.
+	cmd := exec.Command(binaryPath)
+	cmd.Env = append(os.Environ(), lo.MapToSlice(configs, func(k, v string) string {
+		return config.ConfigKeyToEnv(config.DefaultEnvPrefix, k) + "=" + v
+	})...)
+	cmd.Stderr = os.Stderr
+	cmd.Stdout = os.Stdout
+	if err := cmd.Start(); err != nil {
+		t.Fatalf("server %q: failed to start: %v", name, err)
+	}
+
 	g.Go(func() error {
-		cmd := exec.CommandContext(ctx, binaryPath)
-		cmd.Env = append(os.Environ(), lo.MapToSlice(configs, func(k, v string) string {
-			return config.ConfigKeyToEnv(config.DefaultEnvPrefix, k) + "=" + v
-		})...)
-		cmd.Stderr = os.Stderr
-		cmd.Stdout = os.Stdout
-		if err := cmd.Start(); err != nil {
-			return fmt.Errorf("server %q: failed to start: %w", name, err)
+		defer convertCoverageData(t, coverDir, name+"-profile.out")
+
+		// Wait for context cancellation, then send SIGTERM for graceful shutdown
+		<-ctx.Done()
+		if err := cmd.Process.Signal(syscall.SIGTERM); err != nil {
+			t.Logf("server %q: failed to send SIGTERM: %v", name, err)
 		}
+
 		if err := cmd.Wait(); err != nil {
 			if exitErr, ok := err.(*exec.ExitError); ok {
 				if status, ok := exitErr.Sys().(syscall.WaitStatus); ok {
@@ -50,3 +64,11 @@ func startRudderServer(ctx context.Context, g *errgroup.Group, name, binaryPath
 		return nil
 	})
 }
+
+func convertCoverageData(t *testing.T, coverDir, outputFile string) {
+	cmd := exec.Command("go", "tool", "covdata", "textfmt", "-i="+coverDir, "-o="+outputFile)
+	cmd.Stderr = os.Stderr
+	if err := cmd.Run(); err != nil {
+		t.Logf("failed to convert coverage data: %v", err)
+	}
+}