Add fields support for marketplace search details

Co-authored-by: rudrankriyam <[email protected]>

Author: cursoragent

internal/asc/client_http_marketplace_test.go

@@ -17,10 +17,34 @@ func TestGetMarketplaceSearchDetailForApp_SendsRequest(t *testing.T) {
 		if req.URL.Path != "/v1/apps/app-1/marketplaceSearchDetail" {
 			t.Fatalf("expected path /v1/apps/app-1/marketplaceSearchDetail, got %s", req.URL.Path)
 		}
+		if req.URL.RawQuery != "" {
+			t.Fatalf("expected no query params, got %s", req.URL.RawQuery)
+		}
+		assertAuthorized(t, req)
+	}, response)
+
+	if _, err := client.GetMarketplaceSearchDetailForApp(context.Background(), "app-1", nil); err != nil {
+		t.Fatalf("GetMarketplaceSearchDetailForApp() error: %v", err)
+	}
+}
+
+func TestGetMarketplaceSearchDetailForApp_WithFields(t *testing.T) {
+	response := jsonResponse(http.StatusOK, `{"data":{"type":"marketplaceSearchDetails","id":"detail-1","attributes":{"catalogUrl":"https://example.com/catalog"}}}`)
+	client := newTestClient(t, func(req *http.Request) {
+		if req.Method != http.MethodGet {
+			t.Fatalf("expected GET, got %s", req.Method)
+		}
+		if req.URL.Path != "/v1/apps/app-1/marketplaceSearchDetail" {
+			t.Fatalf("expected path /v1/apps/app-1/marketplaceSearchDetail, got %s", req.URL.Path)
+		}
+		values := req.URL.Query()
+		if values.Get("fields[marketplaceSearchDetails]") != "catalogUrl" {
+			t.Fatalf("expected fields catalogUrl, got %q", values.Get("fields[marketplaceSearchDetails]"))
+		}
 		assertAuthorized(t, req)
 	}, response)
 
-	if _, err := client.GetMarketplaceSearchDetailForApp(context.Background(), "app-1"); err != nil {
+	if _, err := client.GetMarketplaceSearchDetailForApp(context.Background(), "app-1", []string{"catalogUrl"}); err != nil {
 		t.Fatalf("GetMarketplaceSearchDetailForApp() error: %v", err)
 	}
 }

internal/asc/client_queries.go

@@ -830,6 +830,12 @@ func buildSubscriptionOfferCodeOneTimeUseCodesQuery(query *subscriptionOfferCode
 	return values.Encode()
 }
 
+func buildMarketplaceSearchDetailsFieldsQuery(fields []string) string {
+	values := url.Values{}
+	addCSV(values, "fields[marketplaceSearchDetails]", fields)
+	return values.Encode()
+}
+
 func buildMarketplaceWebhooksQuery(query *marketplaceWebhooksQuery) string {
 	values := url.Values{}
 	addCSV(values, "fields[marketplaceWebhooks]", query.fields)

internal/asc/marketplace.go

@@ -116,13 +116,16 @@ type MarketplaceWebhookDeleteResult struct {
 }
 
 // GetMarketplaceSearchDetailForApp retrieves marketplace search details for an app.
-func (c *Client) GetMarketplaceSearchDetailForApp(ctx context.Context, appID string) (*MarketplaceSearchDetailResponse, error) {
+func (c *Client) GetMarketplaceSearchDetailForApp(ctx context.Context, appID string, fields []string) (*MarketplaceSearchDetailResponse, error) {
 	appID = strings.TrimSpace(appID)
 	if appID == "" {
 		return nil, fmt.Errorf("appID is required")
 	}
 
 	path := fmt.Sprintf("/v1/apps/%s/marketplaceSearchDetail", appID)
+	if queryString := buildMarketplaceSearchDetailsFieldsQuery(fields); queryString != "" {
+		path += "?" + queryString
+	}
 	data, err := c.do(ctx, "GET", path, nil)
 	if err != nil {
 		return nil, err

internal/cli/marketplace/marketplace_search_details.go

@@ -46,6 +46,7 @@ func MarketplaceSearchDetailsGetCommand() *ffcli.Command {
 	fs := flag.NewFlagSet("get", flag.ExitOnError)
 
 	appID := fs.String("app", "", "App Store Connect app ID (or ASC_APP_ID env)")
+	fields := fs.String("fields", "", "Fields to include: "+strings.Join(marketplaceSearchDetailFieldsList(), ", "))
 	output := fs.String("output", "json", "Output format: json (default), table, markdown")
 	pretty := fs.Bool("pretty", false, "Pretty-print JSON output")
 
@@ -66,6 +67,11 @@ Examples:
 				return flag.ErrHelp
 			}
 
+			fieldsValue, err := normalizeMarketplaceSearchDetailFields(*fields)
+			if err != nil {
+				return fmt.Errorf("marketplace search-details get: %w", err)
+			}
+
 			client, err := getASCClient()
 			if err != nil {
 				return fmt.Errorf("marketplace search-details get: %w", err)
@@ -74,7 +80,7 @@ Examples:
 			requestCtx, cancel := contextWithTimeout(ctx)
 			defer cancel()
 
-			detail, err := client.GetMarketplaceSearchDetailForApp(requestCtx, resolvedAppID)
+			detail, err := client.GetMarketplaceSearchDetailForApp(requestCtx, resolvedAppID, fieldsValue)
 			if err != nil {
 				return fmt.Errorf("marketplace search-details get: failed to fetch: %w", err)
 			}
@@ -245,3 +251,24 @@ Examples:
 		},
 	}
 }
+
+func normalizeMarketplaceSearchDetailFields(value string) ([]string, error) {
+	fields := splitCSV(value)
+	if len(fields) == 0 {
+		return nil, nil
+	}
+	allowed := map[string]struct{}{}
+	for _, field := range marketplaceSearchDetailFieldsList() {
+		allowed[field] = struct{}{}
+	}
+	for _, field := range fields {
+		if _, ok := allowed[field]; !ok {
+			return nil, fmt.Errorf("--fields must be one of: %s", strings.Join(marketplaceSearchDetailFieldsList(), ", "))
+		}
+	}
+	return fields, nil
+}
+
+func marketplaceSearchDetailFieldsList() []string {
+	return []string{"catalogUrl"}
+}

internal/cli/marketplace/marketplace_test.go

@@ -19,6 +19,17 @@ func TestMarketplaceSearchDetailsGetCommand_MissingApp(t *testing.T) {
 	}
 }
 
+func TestMarketplaceSearchDetailsGetCommand_InvalidFields(t *testing.T) {
+	cmd := MarketplaceSearchDetailsGetCommand()
+	if err := cmd.FlagSet.Parse([]string{"--app", "APP_ID", "--fields", "invalid"}); err != nil {
+		t.Fatalf("failed to parse flags: %v", err)
+	}
+
+	if err := cmd.Exec(context.Background(), []string{}); err == nil || err == flag.ErrHelp {
+		t.Fatalf("expected validation error for invalid --fields, got %v", err)
+	}
+}
+
 func TestMarketplaceSearchDetailsCreateCommand_MissingApp(t *testing.T) {
 	t.Setenv("ASC_APP_ID", "")