Backport: Fix Client retries configuration to allow zero retries #2283
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Owner
ruflin
commented
Sep 17, 2025
ruflin
commented
- Changed retries condition from > 0 to >= 0 to allow zero retries
- Fixed type casting issue by casting retries value to int when passing to setRetries()
- Added comprehensive tests for zero retries functionality
- Updated CHANGELOG.md to document the fix
- Added missing setServerless() and getServerless() methods for interface compliance
Backport of #2282
- Added error handler in tests/bootstrap.php to suppress specific deprecation notices - Only applies to PHP 8.5+ where these magic methods are deprecated - Suppresses notices from vendor code (PHPUnit) that we cannot control - Maintains compatibility with older PHP versions
Contributor
|
@ruflin do you plan to tag a new release for this fix? |
Owner
Author
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.