snapshot example without using onRequest #107
Conversation
🦋 Changeset detectedLatest commit: e093495 The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
commit: |
demo/workflows/human-in-the-loop.ts
Outdated
| const snapshot = await getContext().snapshot(); | ||
| return humanInteractionRequestEvent.with({ | ||
| reason: askName.function.arguments, | ||
| snapshot, | ||
| }); |
There was a problem hiding this comment.
good idea, but I'm worry if this will leak the implementation into the workflow
There was a problem hiding this comment.
you could create the snapshot automatically for this event type, e.g.:
const humanInteractionRequestEvent = withSnapshot(workflowEvent<{
reason: string;
}>());
but i think it adds more complexity.
There was a problem hiding this comment.
I feel like calling snapshot in the handler inside is a bad idea
There was a problem hiding this comment.
Don't see a big problem but you can call it implicitly for an event wrapped with withSnapshot
himself65
force-pushed
the
ms/snapshot-review
branch
from
134b294 to
a897a47
Compare
No description provided.