Skip to content

Commit e992038

Browse files
Copilotnitrocode
authored andcommitted
docs: fix typos/grammar, add typos + Vale prose-lint CI (#6252)
Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: nitrocode <7775707+nitrocode@users.noreply.github.com> Signed-off-by: Daan Vinken <dvinken@tesla.com>
1 parent fe70a9c commit e992038

File tree

13 files changed

+65
-23
lines changed

13 files changed

+65
-23
lines changed
Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
extends: substitution
2+
message: "Use '%s' instead of '%s'."
3+
level: error
4+
ignorecase: false
5+
swap:
6+
'Github': 'GitHub'
7+
'Gitlab': 'GitLab'

.github/workflows/website.yml

Lines changed: 20 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -45,6 +45,9 @@ jobs:
4545
- 'package-lock.json'
4646
- 'package.json'
4747
- '.github/workflows/website.yml'
48+
- '.vale.ini'
49+
- '_typos.toml'
50+
- '.github/styles/**'
4851
4952
# Check that the website builds and there's no missing links.
5053
website-check:
@@ -60,6 +63,23 @@ jobs:
6063

6164
- uses: actions/checkout@34e114876b0b11c390a56381ad16ebd13914f8d5 # v4
6265

66+
- name: Spell check
67+
uses: crate-ci/typos@57b11c6b7e54c402ccd9cda953f1072ec4f78e33 # v1.43.5
68+
with:
69+
files: ./runatlantis.io/docs
70+
71+
- name: Vale prose linting
72+
run: |
73+
VALE_VERSION="3.9.4"
74+
VALE_TARBALL="vale_${VALE_VERSION}_Linux_64-bit.tar.gz"
75+
curl -sLO "https://github.com/errata-ai/vale/releases/download/v${VALE_VERSION}/${VALE_TARBALL}"
76+
echo "551f7ef5cabd53affb7b2c8bdbd4cfb6216270d53c4d6e571a567c5b5df0921d ${VALE_TARBALL}" | sha256sum --check
77+
tar xz -C /tmp vale -f "${VALE_TARBALL}"
78+
rm "${VALE_TARBALL}"
79+
# api-endpoints.md intentionally uses "Github"/"Gitlab" as literal API
80+
# string values matching the Go source code constants; exclude it here.
81+
/tmp/vale --glob='!*api-endpoints.md' runatlantis.io/docs/
82+
6383
- name: markdown-lint
6484
uses: DavidAnson/markdownlint-cli2-action@05f32210e84442804257b2a6f20b273450ec8265 # v19
6585
with:

.vale.ini

Lines changed: 8 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,8 @@
1+
StylesPath = .github/styles
2+
MinAlertLevel = error
3+
4+
# api-endpoints.md intentionally uses the API string literals "Github" and
5+
# "Gitlab" (which match the Go source code constants). When running Vale
6+
# locally, exclude it with: vale --glob='!*api-endpoints.md' runatlantis.io/docs/
7+
[*.md]
8+
BasedOnStyles = Atlantis

_typos.toml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,7 @@
1+
[default.extend-words]
2+
# HashiCorp is a proper company name; the "Hashi" prefix is intentional
3+
hashi = "hashi"
4+
# "ue" is used as a workspace-name prefix in documentation examples (short for us-east)
5+
ue = "ue"
6+
# ACI = Azure Container Instances
7+
aci = "aci"

runatlantis.io/docs/command-requirements.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,7 +23,7 @@ by at least one person other than the author.
2323

2424
#### Usage
2525

26-
The `approved` requirement by:
26+
Set the `approved` requirement by:
2727

2828
1. Creating a `repos.yaml` file with the `apply_requirements` key:
2929

@@ -239,7 +239,7 @@ having that apply requirement set.
239239

240240
If you only want some projects/repos to have apply requirements, then you must
241241

242-
1. Specifying which repos have which requirements via the `repos.yaml` file.
242+
1. Specify which repos have which requirements via the `repos.yaml` file.
243243

244244
```yaml
245245
repos:

runatlantis.io/docs/custom-workflows.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -748,7 +748,7 @@ Full:
748748
| multienv.command | string | none | yes | Name of the custom script to run |
749749
| multienv.shell | string | "sh" | no | Name of the shell to use for command execution |
750750
| multienv.shellArgs | string or []string | "-c" | no | Command line arguments to be passed to the shell. Cannot be set without `shell` |
751-
| multienv.output | string | "show" | no | Setting output to "hide" will suppress the message obout added environment variables |
751+
| multienv.output | string | "show" | no | Setting output to "hide" will suppress the message about added environment variables |
752752

753753
The output of the command execution must have the following format:
754754
`EnvVar1Name=value1,EnvVar2Name=value2,EnvVar3Name=value3`

runatlantis.io/docs/how-atlantis-works.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
# How Atlantis Works
22

3-
This section of docs talks about how Atlantis at deeper level.
3+
This section of docs talks about how Atlantis works at a deeper level.
44

55
* [Locking](locking.md)
66
* [Autoplanning](autoplanning.md)

runatlantis.io/docs/repo-level-atlantis-yaml.md

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -309,7 +309,7 @@ projects:
309309

310310
:::warning
311311
`plan_requirements`, `apply_requirements` and `import_requirements` are restricted keys so this repo will need to be configured
312-
to be allowed to set this key. See [Server-Side Repo Config Use Cases](server-side-repo-config.md#repos-can-set-their-own-apply-an-applicable-subcommand).
312+
to be allowed to set this key. See [Server-Side Repo Config Use Cases](server-side-repo-config.md#repos-can-set-their-own-apply-requirements).
313313
:::
314314

315315
### Order of planning/applying
@@ -471,8 +471,8 @@ workflow: myworkflow
471471
| name | string | none | maybe | Required if there is more than one project with the same `dir` and `workspace`. This project name can be used with the `-p` flag. |
472472
| branch | string | none | no | Regex matching projects by the base branch of pull request (the branch the pull request is getting merged into). Only projects that match the PR's branch will be considered. By default, all branches are matched. |
473473
| dir | string | none | **yes** | The directory of this project relative to the repo root. For example if the project was under `./project1` then use `project1`. Use `.` to indicate the repo root. |
474-
| workspace | string | `"default"` | no | The [Terraform workspace](https://developer.hashicorp.com/terraform/language/state/workspaces) for this project. Atlantis will switch to this workplace when planning/applying and will create it if it doesn't exist. |
475-
| execution_order_group | int | `0` | no | Index of execution order group. Projects will be sort by this field before planning/applying. |
474+
| workspace | string | `"default"` | no | The [Terraform workspace](https://developer.hashicorp.com/terraform/language/state/workspaces) for this project. Atlantis will switch to this workspace when planning/applying and will create it if it doesn't exist. |
475+
| execution_order_group | int | `0` | no | Index of execution order group. Projects will be sorted by this field before planning/applying. |
476476
| delete_source_branch_on_merge | bool | `false` | no | Automatically deletes the source branch on merge. |
477477
| repo_locking | bool | `true` | no | (deprecated) Get a repository lock in this project when plan. |
478478
| repo_locks | [RepoLocks](#repolocks) | `mode: on_plan` | no | Get a repository lock in this project on plan or apply. See [RepoLocks](#repolocks) for more details. |

runatlantis.io/docs/security.md

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -76,7 +76,7 @@ Even with the `--repo-allowlist` flag set, without a webhook secret, attackers c
7676
Webhook secrets ensure that the webhook requests are actually coming from your VCS provider (GitHub or GitLab).
7777
7878
:::tip Tip
79-
If you are using Azure DevOps, instead of webhook secrets add a [basic username and password](#azure devops basic authentication)
79+
If you are using Azure DevOps, instead of webhook secrets add a [basic username and password](#azure-devops-basic-authentication)
8080
:::
8181
8282
### Azure DevOps Basic Authentication
@@ -91,7 +91,7 @@ flags.
9191
9292
### Enable Authentication on Atlantis Web Server
9393
94-
It is very recommended to enable authentication in the web service. Enable BasicAuth using the `--web-basic-auth=true` and setup a username and a password using `--web-username=yourUsername` and `--web-password=yourPassword` flags.
94+
It is highly recommended to enable authentication in the web service. Enable BasicAuth using the `--web-basic-auth=true` and set up a username and a password using `--web-username=yourUsername` and `--web-password=yourPassword` flags.
9595
9696
You can also pass these as environment variables `ATLANTIS_WEB_BASIC_AUTH=true` `ATLANTIS_WEB_USERNAME=yourUsername` and `ATLANTIS_WEB_PASSWORD=yourPassword`.
9797

runatlantis.io/docs/server-configuration.md

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -543,8 +543,8 @@ Defaults to "" (empty string).
543543
::: warning NOTE
544544
Each VCS provider supports a different list of emojis:
545545

546-
- [Github](https://docs.github.com/en/rest/reactions/reactions?apiVersion=2022-11-28#about-reactions)
547-
- [Gitlab](https://gitlab.com/gitlab-org/gitlab/-/blob/master/fixtures/emojis/digests.json)
546+
- [GitHub](https://docs.github.com/en/rest/reactions/reactions?apiVersion=2022-11-28#about-reactions)
547+
- [GitLab](https://gitlab.com/gitlab-org/gitlab/-/blob/master/fixtures/emojis/digests.json)
548548
- [Azure DevOps](https://learn.microsoft.com/en-us/azure/devops/project/wiki/markdown-guidance?view=azure-devops#emoji)
549549

550550
:::
@@ -744,7 +744,7 @@ In versions v0.35.0 and later, the GitHub team name can only be a slug because i
744744

745745
In versions between v0.21.0 and v0.34.0, the GitHub team name can be a name or a slug.
746746

747-
In versions v0.20.1 and below, the Github team name required the case sensitive team name.
747+
In versions v0.20.1 and below, the GitHub team name required the case sensitive team name.
748748

749749
Comma-separated list of GitHub teams and permission pairs.
750750

@@ -889,7 +889,7 @@ atlantis server --gitlab-hostname="my.gitlab.enterprise.com"
889889
ATLANTIS_GITLAB_HOSTNAME="my.gitlab.enterprise.com"
890890
```
891891

892-
Hostname of your GitLab Enterprise installation. If using [Gitlab.com](https://gitlab.com),
892+
Hostname of your GitLab Enterprise installation. If using [GitLab.com](https://gitlab.com),
893893
don't set. Defaults to `gitlab.com`.
894894

895895
### `--gitlab-status-retry-enabled`
@@ -1484,7 +1484,7 @@ This flag is useful when having multiple projects that need to run a plan and ap
14841484
- [plugin_cache_dir concurrently discussion](https://github.com/hashicorp/terraform/issues/31964)
14851485
- [PR to improve the situation](https://github.com/hashicorp/terraform/pull/33479)
14861486

1487-
The effect of the race condition is more evident when using parallel configuration to run plan and apply, by disabling the use of plugin cache will impact in the performance when starting a new plan or apply, but in large atlantis deployments with multiple projects and shared modules the use of `--parallel_plan` and `--parallel_apply` is mandatory for an efficient management of the PRs.
1487+
The effect of the race condition is more evident when using parallel configuration to run plan and apply. Disabling the use of plugin cache will impact the performance when starting a new plan or apply, but in large Atlantis deployments with multiple projects and shared modules the use of `--parallel_plan` and `--parallel_apply` is mandatory for an efficient management of the PRs.
14881488

14891489
### `--var-file-allowlist` <Badge text="v0.19.5" type="info"/>
14901490

0 commit comments

Comments
 (0)