Atlantis runs plans on PRs even when no files matching when_modified patterns have changed

[knjoroge]

Community Note

• Please vote on this issue by adding a 👍 reaction to the original issue to help the community and maintainers prioritize this request. Searching for pre-existing feature requests helps us consolidate datapoints for identical requirements into a single place, thank you!
• Please do not leave "+1" or other comments that do not add relevant new information or questions, they generate extra noise for issue followers and do not help prioritize the request.
• If you are interested in working on this issue or have submitted a pull request, please leave a comment.

---

Overview of the Issue

Atlantis is running plans on all pull requests, even when no files matching the patterns in the when_modified configuration have been modified. This is causing unnecessary plan executions and blocking the auto-merging of pull requests. This configuration has been working just fine. This started occurring about a week or two ago. Have any recent updates introduced a bug?

---

Environment details

Atlantis version: 0.33.0
Deployment method: Terraform module https://github.com/runatlantis/terraform-gce-atlantis
VCS: GitHub
Terraform version: v1.6.3

---

Logs

atlantis-server.yaml file:

repos:
- id: github.com/xxxx/monorepo
  apply_requirements: [mergeable]
  allowed_overrides: [workflow]

Atlantis server flags:

ATLANTIS_SILENCE_VCS_STATUS_NO_PLANS = true
ATLANTIS_SILENCE_VCS_STATUS_NO_PROJECTS = true
ATLANTIS_SILENCE_NO_PROJECTS = true
ATLANTIS_HIDE_PREV_PLAN_COMMENTS = true
ATLANTIS_HIDE_UNCHANGED_PLAN_COMMENTS = true

atlantis.yaml file:

version: 3
projects:
- name: 6-app-test-sandbox
  dir: infrastructure-gcp/6-app-test/environments/sandbox
  autoplan:
    when_modified:
    - '*.tf'
    - ../../modules/**/*.tf
    - ../../6-app-modules/**/*.tf
    - '**/*.tfvars'
    - ../../config/**/*.yaml
    - ../../modules/**/*.yaml
  workspace: default
  workflow: default
  terraform_version: v1.6.3

[dosubot]

Hey @knjoroge! I'm here to help you squash bugs, answer questions, and even become a contributor. Let's tackle this Atlantis issue together! 🤖

The issue you're experiencing, where Atlantis runs plans on pull requests even when no files matching the when_modified patterns have changed, might be related to recent updates that introduced support for exclusions in the when_modified configuration. This change allows you to ignore changes in specific files that you don't want to trigger a plan on, using a syntax similar to .dockerignore ^[1].

Here are a few things you might want to check or try:

1. Pattern Matching: Ensure that the patterns in your when_modified configuration are correctly specified and match the files you intend to monitor. The patterns use .dockerignore syntax, which allows for flexible pattern matching, including the use of wildcards and exclusions ^[2].

2. Exclusions: If you have recently added exclusions to your when_modified configuration, verify that they are correctly implemented. Incorrect exclusions might cause unexpected behavior ^[1].

3. Recent Changes: Since the issue started occurring recently, it might be worth reviewing any changes made to your Atlantis configuration or the repository structure around the time the issue began.

4. Atlantis Version: Ensure that you are using the latest version of Atlantis, as updates might include bug fixes related to this behavior.

If the problem persists, it might be beneficial to review the logs for any anomalies or errors that could provide more insight into why plans are being triggered unexpectedly.

To continue talking to Dosu, mention @dosu.

---

^{Help Dosu learn! Give it feedback: Great Response | Irrelevant Answer | Incorrect Sources | Too Verbose | Hallucination | Bug Report | Other}

[commarla]

Hey, I'm experiencing the same issue with version 0.33. I rolled back to Atlantis 0.28.5 (the previous version we were using), and the bug no longer occurs.

[commarla]

I upgraded step by step from version 0.28.5 to 0.33, and the issue appeared between 0.32 and 0.33.

[knjoroge]

Hi @commarla, thanks for checking! You're right, I no longer see this issue when I set the version to 0.31

[X-Guardian]

Hi @knjoroge. Thanks for reporting this. I have reproduced it myself and am working on a fix.

[chriskuchin]

@X-Guardian any update on the patch for this? We had to roll back because of this behavior

[pachecoc]

Hi. I am still waiting for this patch.

In the meantime, I had to disable the flags that contains silence VCS_STATUS.
Doing this I do not have the stuck pending check but instead I have the plans and applies to 0/0 projects.

I know that it is not the ideal, but I believe we will have a solution for that soon.
Looking forward to it.
Thank you

[X-Guardian]

@X-Guardian any update on the patch for this? We had to roll back because of this behavior

It will be done when it is done. Please don't act entitled when you have made no contributions to this project.

[chriskuchin]

I apologize if you took that wrong but I have been a long time user and tried to help when I can on multiple issues. I wasn't trying to rush just wondering on ETA.

[prune998]

@X-Guardian do you have any news ?
Do you need any help ? If you have any clue at where the problem is, I could have a peak an try to PR. Let me know if there is anything I can do.

Thanks

[zmaupin]

Also curious about the patch status. We had to roll back as well. I get that this is a volunteer effort, but pushing people away with attitude doesn’t help anyone.