feat(atlantis): allow restartPolicy on containers for native sidecars (#563)

The bundled values.schema.json carries an older k8s Container definition (additionalProperties: false) that predates the restartPolicy field added to Container in k8s 1.28. This rejected init containers declared as native sidecars (an initContainers entry with restartPolicy: Always):

  at '/initContainers/0': additional properties 'restartPolicy' not allowed

Add restartPolicy to the Container definition so initContainers and extraContainers can declare native sidecars. Additive and renders nothing differently by default. Adds a statefulset unittest covering the case.

Signed-off-by: DrFaust92 <ilia.lazebnik@placer.ai>

Author: DrFaust92

charts/atlantis/Chart.yaml

@@ -3,7 +3,7 @@ apiVersion: v1
 appVersion: v0.45.0
 description: A Helm chart for Atlantis https://www.runatlantis.io
 name: atlantis
-version: 6.9.0
+version: 6.9.1
 keywords:
   - terraform
 home: https://www.runatlantis.io

charts/atlantis/tests/statefulset_test.yaml

@@ -258,6 +258,20 @@ tests:
       - equal:
           path: spec.template.spec.hostNetwork
           value: true
+  - it: native sidecar via initContainers restartPolicy
+    template: statefulset.yaml
+    set:
+      initContainers:
+        - name: sidecar
+          image: busybox:latest
+          restartPolicy: Always
+    asserts:
+      - equal:
+          path: spec.template.spec.initContainers[0].name
+          value: sidecar
+      - equal:
+          path: spec.template.spec.initContainers[0].restartPolicy
+          value: Always
   - it: serviceAccountName
     template: statefulset.yaml
     set:

charts/atlantis/values.schema.json

@@ -1620,6 +1620,10 @@
           "$ref": "#/definitions/io.k8s.api.core.v1.ResourceRequirements",
           "description": "Compute Resources required by this container. Cannot be updated. More info: https://kubernetes.io/docs/concepts/configuration/manage-resources-containers/"
         },
+        "restartPolicy": {
+          "description": "RestartPolicy defines the restart behavior of individual containers in a pod. This field may only be set for init containers, and the only allowed value is \"Always\". For non-init containers or when this field is not specified, the restart behavior is defined by the Pod's restart policy and the container type. Setting the RestartPolicy as \"Always\" for the init container will have the following effect: this init container will be continually restarted on exit until all regular containers have terminated. Once all regular containers have completed, all init containers with restartPolicy \"Always\" will be shut down. This lifecycle differs from normal init containers and is often referred to as a \"sidecar\" container.",
+          "type": "string"
+        },
         "securityContext": {
           "$ref": "#/definitions/io.k8s.api.core.v1.SecurityContext",
           "description": "SecurityContext defines the security options the container should be run with. If set, the fields of SecurityContext override the equivalent fields of PodSecurityContext. More info: https://kubernetes.io/docs/tasks/configure-pod-container/security-context/"