feat(atlantis): add service.extraPorts for additional service ports (#560)

Allow exposing extra ports on the Atlantis Service (e.g. an auth-proxy
sidecar) without forking the chart. Renders nothing when empty, so the
default service output is unchanged.

Signed-off-by: DrFaust92 <ilia.lazebnik@placer.ai>

Author: DrFaust92

charts/atlantis/Chart.yaml

@@ -3,7 +3,7 @@ apiVersion: v1
 appVersion: v0.44.0
 description: A Helm chart for Atlantis https://www.runatlantis.io
 name: atlantis
-version: 6.6.0
+version: 6.7.0
 keywords:
   - terraform
 home: https://www.runatlantis.io

charts/atlantis/README.md

@@ -265,6 +265,7 @@ Optionally, set `service.internalTrafficPolicy: Local` or `Cluster` depending on
 | secret.annotations | object | `{}` | Annotations for the Secrets. Check values.yaml for examples. |
 | service.annotations | object | `{}` |  |
 | service.externalTrafficPolicy | string | `nil` |  |
+| service.extraPorts | list | `[]` | [optional] Additional ports to expose on the service, e.g. for an auth proxy sidecar. Each entry is a standard Service port object. |
 | service.internalTrafficPolicy | string | `nil` | [optional] Internal traffic policy for the Service. One of: Cluster, Local. |
 | service.loadBalancerIP | string | `nil` |  |
 | service.loadBalancerSourceRanges | list | `[]` |  |

charts/atlantis/templates/service.yaml

@@ -44,6 +44,9 @@ spec:
     {{- end }}
       protocol: TCP
       name: {{ .Values.service.portName }}
+    {{- with .Values.service.extraPorts }}
+    {{- toYaml . | nindent 4 }}
+    {{- end }}
   selector:
     app: {{ template "atlantis.name" . }}
     release: {{ .Release.Name }}

charts/atlantis/tests/service_test.yaml

@@ -103,3 +103,22 @@ tests:
       - equal:
           path: metadata.labels.team
           value: infra
+  - it: extraPorts
+    set:
+      service:
+        extraPorts:
+          - name: auth-proxy
+            port: 4180
+            protocol: TCP
+            targetPort: auth-proxy
+    asserts:
+      - equal:
+          path: spec.ports[1]
+          value:
+            name: auth-proxy
+            port: 4180
+            protocol: TCP
+            targetPort: auth-proxy
+      - lengthEqual:
+          path: spec.ports
+          count: 2

charts/atlantis/values.schema.json

@@ -568,6 +568,14 @@
           ],
           "default": 4141
         },
+        "extraPorts": {
+          "description": "Additional ports to expose on the service, e.g. for an auth proxy sidecar.",
+          "type": "array",
+          "items": {
+            "type": "object"
+          },
+          "default": []
+        },
         "externalTrafficPolicy": {
           "description": "externalTrafficPolicy to set on service.",
           "type": [

charts/atlantis/values.yaml

@@ -311,6 +311,8 @@ service:
   nodePort: null
   # -- (int) [optional] Define the port you would like atlantis to run on. Defaults to 4141.
   targetPort: 4141
+  # -- (list) [optional] Additional ports to expose on the service, e.g. for an auth proxy sidecar. Each entry is a standard Service port object.
+  extraPorts: []
   loadBalancerIP: null
   loadBalancerSourceRanges: []
   externalTrafficPolicy: null