Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(annotations): add secret annotations #458

Merged
merged 5 commits into from
Feb 26, 2025

Conversation

al-cheb
Copy link
Contributor

@al-cheb al-cheb commented Feb 20, 2025

what

Allow adding annotations to secret resources.

why

My use case is that I want to use vault-webhool to reflect secrets without define annotations for all resources when we use the extraAnnotations param.

@al-cheb al-cheb requested a review from a team as a code owner February 20, 2025 09:01
@al-cheb al-cheb force-pushed the add-secret-annotations branch 3 times, most recently from 84c2712 to 5e8a182 Compare February 20, 2025 09:16
Allow adding annotations to secret resources.

Signed-off-by: Alexander Chebotov <[email protected]>

bump up chart version

update docs

Signed-off-by: Alexander Chebotov <[email protected]>

fix readme

Signed-off-by: Alexander Chebotov <[email protected]>
@al-cheb al-cheb force-pushed the add-secret-annotations branch from 5e8a182 to 16a6ad0 Compare February 20, 2025 09:17
Alexander Chebotov added 3 commits February 26, 2025 09:58
Signed-off-by: Alexander Chebotov <[email protected]>
Signed-off-by: Alexander Chebotov <[email protected]>
Signed-off-by: Alexander Chebotov <[email protected]>
@GMartinez-Sisti GMartinez-Sisti merged commit 49e6b48 into runatlantis:main Feb 26, 2025
5 checks passed
@al-cheb al-cheb deleted the add-secret-annotations branch February 26, 2025 15:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants