Skip to content

Commit 9264297

Browse files
authored
fix: removing mode from the decorator (#261)
1 parent 536b9b9 commit 9264297

File tree

2 files changed

+6
-17
lines changed

2 files changed

+6
-17
lines changed

src/galileo/decorator.py

Lines changed: 5 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -749,11 +749,7 @@ async def _wrap_async_generator_result(
749749
self._handle_call_result(span_type, span_params, output)
750750

751751
def get_logger_instance(
752-
self,
753-
project: Optional[str] = None,
754-
log_stream: Optional[str] = None,
755-
experiment_id: Optional[str] = None,
756-
mode: Optional[str] = None,
752+
self, project: Optional[str] = None, log_stream: Optional[str] = None, experiment_id: Optional[str] = None
757753
) -> GalileoLogger:
758754
"""
759755
Get the Galileo Logger instance for the current decorator context.
@@ -770,7 +766,6 @@ def get_logger_instance(
770766
project=project or _project_context.get(),
771767
log_stream=log_stream or _log_stream_context.get(),
772768
experiment_id=experiment_id or _experiment_id_context.get(),
773-
mode=mode or _mode_context.get(),
774769
)
775770

776771
def get_current_project(self) -> Optional[str]:
@@ -823,11 +818,7 @@ def get_current_mode(self) -> Optional[str]:
823818
return _mode_context.get()
824819

825820
def flush(
826-
self,
827-
project: Optional[str] = None,
828-
log_stream: Optional[str] = None,
829-
experiment_id: Optional[str] = None,
830-
mode: Optional[str] = None,
821+
self, project: Optional[str] = None, log_stream: Optional[str] = None, experiment_id: Optional[str] = None
831822
) -> None:
832823
"""
833824
Upload all captured traces under a project and log stream context to Galileo.
@@ -838,7 +829,7 @@ def flush(
838829
project: The project name. Defaults to None.
839830
log_stream: The log stream name. Defaults to None.
840831
"""
841-
self.get_logger_instance(project=project, log_stream=log_stream, experiment_id=experiment_id, mode=mode).flush()
832+
self.get_logger_instance(project=project, log_stream=log_stream, experiment_id=experiment_id).flush()
842833

843834
if project == _project_context.get() and log_stream == _log_stream_context.get():
844835
_span_stack_context.set([])
@@ -868,7 +859,6 @@ def reset(self) -> None:
868859
project=_project_context.get(),
869860
log_stream=_log_stream_context.get(),
870861
experiment_id=_experiment_id_context.get(),
871-
mode=_mode_context.get(),
872862
)
873863
# Reset current context values
874864
_project_context.set(None)
@@ -896,7 +886,6 @@ def init(
896886
project: Optional[str] = None,
897887
log_stream: Optional[str] = None,
898888
experiment_id: Optional[str] = None,
899-
mode: Optional[str] = None,
900889
local_metrics: Optional[list[LocalMetricConfig]] = None,
901890
) -> None:
902891
"""
@@ -912,9 +901,9 @@ def init(
912901
experiment_id: The experiment id. Defaults to None.
913902
local_metrics: Local metrics configs to run on the traces/spans before submitting them for ingestion. Defaults to None.
914903
"""
915-
GalileoLoggerSingleton().reset(project=project, log_stream=log_stream, experiment_id=experiment_id, mode=mode)
904+
GalileoLoggerSingleton().reset(project=project, log_stream=log_stream, experiment_id=experiment_id)
916905
GalileoLoggerSingleton().get(
917-
project=project, log_stream=log_stream, experiment_id=experiment_id, mode=mode, local_metrics=local_metrics
906+
project=project, log_stream=log_stream, experiment_id=experiment_id, local_metrics=local_metrics
918907
)
919908

920909
_project_context.set(project)

src/galileo/utils/singleton.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ def get(
121121
"log_stream": log_stream,
122122
"experiment_id": experiment_id,
123123
"local_metrics": local_metrics,
124-
"mode": mode,
124+
"experimental": {"mode": mode},
125125
}
126126
# Create the logger with filtered kwargs.
127127
logger = GalileoLogger(**{k: v for k, v in galileo_client_init_args.items() if v is not None})

0 commit comments

Comments
 (0)