fix hook and codex sync edge cases

Author: talvak

cmd/skillshare/doctor.go

@@ -1167,6 +1167,12 @@ func checkHooks(sourceRoot, projectRoot string, result *doctorResult) {
 	}
 	var details []string
 	for _, bundle := range bundles {
+		if len(bundle.Issues) > 0 {
+			for _, issue := range bundle.Issues {
+				details = append(details, fmt.Sprintf("%s: %s", bundle.Name, issue))
+			}
+			continue
+		}
 		for _, target := range hookpkg.SupportedTargets(bundle) {
 			if _, err := os.Stat(hookpkg.RenderRoot(projectRoot, bundle.Name, target)); err != nil {
 				details = append(details, fmt.Sprintf("%s: %s hooks not rendered", bundle.Name, target))

cmd/skillshare/hooks.go

@@ -55,7 +55,14 @@ func cmdHooksList(args []string) error {
 	}
 	ui.Header(ui.WithModeLabel("Hooks"))
 	for _, bundle := range bundles {
-		ui.Info("%s  claude=%d codex=%d", bundle.Name, bundle.Targets["claude"], bundle.Targets["codex"])
+		summary := fmt.Sprintf("claude=%d codex=%d", bundle.Targets["claude"], bundle.Targets["codex"])
+		if len(bundle.Issues) > 0 {
+			summary += fmt.Sprintf(" issues=%d", len(bundle.Issues))
+		}
+		ui.Info("%s  %s", bundle.Name, summary)
+		for _, issue := range bundle.Issues {
+			ui.Info("  %s", issue)
+		}
 	}
 	return nil
 }

cmd/skillshare/hooks_test.go

@@ -117,3 +117,33 @@ func TestCmdHooksSyncTextShowsWarningsForRenderedBundles(t *testing.T) {
 		t.Fatalf("expected warning output, got %s", output)
 	}
 }
+
+func TestCmdHooksSyncTextShowsInvalidBundleWarnings(t *testing.T) {
+	root := t.TempDir()
+	oldWD, err := os.Getwd()
+	if err != nil {
+		t.Fatalf("getwd: %v", err)
+	}
+	if err := os.Chdir(root); err != nil {
+		t.Fatalf("chdir: %v", err)
+	}
+	t.Cleanup(func() {
+		_ = os.Chdir(oldWD)
+	})
+
+	if err := os.MkdirAll(filepath.Join(root, ".skillshare", "hooks", "broken"), 0o755); err != nil {
+		t.Fatalf("mkdir broken: %v", err)
+	}
+	if err := os.WriteFile(filepath.Join(root, ".skillshare", "hooks", "broken", "hook.yaml"), []byte("claude:\n  events:\n    SessionStart:\n      - command: \"{OTHER_ROOT}/scripts/start.sh\"\n"), 0o644); err != nil {
+		t.Fatalf("write broken hook: %v", err)
+	}
+
+	output := stripANSIWarnings(captureStdout(t, func() {
+		if err := cmdHooksSync([]string{"-p", "broken", "--target", "all"}); err != nil {
+			t.Fatalf("cmdHooksSync: %v", err)
+		}
+	}))
+	if !strings.Contains(output, "broken:") || !strings.Contains(output, "hook.yaml") {
+		t.Fatalf("expected invalid bundle warning output, got %s", output)
+	}
+}

cmd/skillshare/init_test.go

@@ -36,6 +36,7 @@ func TestCommitSourceFiles_CommitFailureIsReturned(t *testing.T) {
 	runGit(t, repo, "init")
 	runGit(t, repo, "config", "user.email", "test@example.com")
 	runGit(t, repo, "config", "user.name", "Test User")
+	runGit(t, repo, "config", "core.hooksPath", filepath.Join(".git", "hooks"))
 
 	hookPath := filepath.Join(repo, ".git", "hooks", "pre-commit")
 	if err := os.WriteFile(hookPath, []byte("#!/bin/sh\nexit 1\n"), 0o755); err != nil {

cmd/skillshare/status.go

@@ -147,7 +147,14 @@ func cmdStatus(args []string) error {
 		if bundles, bundleErr := hookpkg.Discover(cfg.EffectiveHooksSource()); bundleErr == nil && len(bundles) > 0 {
 			ui.Header("Hooks")
 			for _, bundle := range bundles {
-				ui.Status(bundle.Name, "hook", fmt.Sprintf("claude=%d codex=%d", bundle.Targets["claude"], bundle.Targets["codex"]))
+				summary := fmt.Sprintf("claude=%d codex=%d", bundle.Targets["claude"], bundle.Targets["codex"])
+				if len(bundle.Issues) > 0 {
+					summary += fmt.Sprintf(" issues=%d", len(bundle.Issues))
+				}
+				ui.Status(bundle.Name, "hook", summary)
+				for _, issue := range bundle.Issues {
+					ui.Info("  %s", issue)
+				}
 			}
 		}
 

cmd/skillshare/status_project.go

@@ -59,7 +59,14 @@ func cmdStatusProject(root string) error {
 	if bundles, bundleErr := hookpkg.Discover(config.HooksSourceDirProject(root)); bundleErr == nil && len(bundles) > 0 {
 		ui.Header("Hooks")
 		for _, bundle := range bundles {
-			ui.Status(bundle.Name, "hook", fmt.Sprintf("claude=%d codex=%d", bundle.Targets["claude"], bundle.Targets["codex"]))
+			summary := fmt.Sprintf("claude=%d codex=%d", bundle.Targets["claude"], bundle.Targets["codex"])
+			if len(bundle.Issues) > 0 {
+				summary += fmt.Sprintf(" issues=%d", len(bundle.Issues))
+			}
+			ui.Status(bundle.Name, "hook", summary)
+			for _, issue := range bundle.Issues {
+				ui.Info("  %s", issue)
+			}
 		}
 	}