Skip to content

Commit 7a5d713

Browse files
ryan-williamsclaude
andcommitted
convert plots/, plot_api/, cartesian/ to TypeScript
57 files: 13 plots/ root, 13 plot_api/, 31 cartesian/. Includes the biggest files: axes.ts (4,700L), plot_api.ts (3,800L), plots.ts (3,300L), dragbox.ts (1,400L), set_convert.ts (900L). Total: 221 .ts / 614 .js (26% converted). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
1 parent 57f6549 commit 7a5d713

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

58 files changed

+919
-919
lines changed

src/components/fx/click.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
import Registry from '../../registry.js';
22
import { hover } from './hover.js';
33

4-
export default function click(gd: any, evt: any, subplot: any): void {
4+
export default function click(gd: any, evt: any, subplot?: any): void {
55
var annotationsDone = Registry.getComponentMethod('annotations', 'onClick')(gd, gd._hoverdata);
66

77
// fallback to fail-safe in case the plot type's hover method doesn't pass the subplot.
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,6 @@
11
import Registry from '../registry.js';
22

3-
export default function containerArrayMatch(astr) {
3+
export default function containerArrayMatch(astr?: any): any {
44
var rootContainers = Registry.layoutArrayContainers;
55
var regexpContainers = Registry.layoutArrayRegexes;
66
var rootPart = astr.split('[')[0];
Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -83,7 +83,7 @@ export default {
8383
overrideAll: overrideAll
8484
};
8585

86-
function falseObj(keys) {
86+
function falseObj(keys?: any): any {
8787
var out = {};
8888
for(var i = 0; i < keys.length; i++) out[keys[i]] = false;
8989
return out;
@@ -104,7 +104,7 @@ function falseObj(keys) {
104104
*
105105
* @return {object} a new attributes object with `editType` modified as directed
106106
*/
107-
function overrideAll(attrs, editTypeOverride, overrideContainers) {
107+
function overrideAll(attrs?: any, editTypeOverride?: any, overrideContainers?: any): any {
108108
var out = extendFlat({}, attrs);
109109
for(var key in out) {
110110
var attr = out[key];
@@ -117,7 +117,7 @@ function overrideAll(attrs, editTypeOverride, overrideContainers) {
117117
return out;
118118
}
119119

120-
function overrideOne(attr, editTypeOverride, overrideContainers, key) {
120+
function overrideOne(attr?: any, editTypeOverride?: any, overrideContainers?: any, key?: any): any {
121121
if(attr.valType) {
122122
var out = extendFlat({}, attr);
123123
out.editType = editTypeOverride;
Lines changed: 15 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -12,15 +12,15 @@ var traceIs = Registry.traceIs;
1212

1313
const AX_LETTERS = ['x', 'y', 'z'];
1414

15-
export var clearPromiseQueue = function (gd) {
15+
export var clearPromiseQueue = function (gd?: any) {
1616
if (Array.isArray(gd._promises) && gd._promises.length > 0) {
1717
log('Clearing previous rejected promises from queue.');
1818
}
1919

2020
gd._promises = [];
2121
};
2222

23-
export var cleanLayout = function (layout) {
23+
export var cleanLayout = function (layout?: any) {
2424
var i, j;
2525

2626
if (!layout) layout = {};
@@ -146,15 +146,15 @@ export var cleanLayout = function (layout) {
146146
return layout;
147147
};
148148

149-
function cleanAxRef(container, attr) {
149+
function cleanAxRef(container?: any, attr?: any): any {
150150
var valIn = container[attr];
151151
var axLetter = attr.charAt(0);
152152
if (valIn && valIn !== 'paper') {
153153
container[attr] = cleanId(valIn, axLetter, true);
154154
}
155155
}
156156

157-
export var cleanData = function (data) {
157+
export var cleanData = function (data?: any) {
158158
for (var tracei = 0; tracei < data.length; tracei++) {
159159
var trace = data[tracei];
160160
var i;
@@ -281,7 +281,7 @@ export var cleanData = function (data) {
281281
}
282282
};
283283

284-
function cleanFinanceDir(dirContainer) {
284+
function cleanFinanceDir(dirContainer?: any): any {
285285
if (!isPlainObject(dirContainer)) return false;
286286

287287
var dirName = dirContainer.name;
@@ -292,7 +292,7 @@ function cleanFinanceDir(dirContainer) {
292292
return (typeof dirName === 'string' || typeof dirName === 'number') && String(dirName);
293293
}
294294

295-
function commonPrefix(name1, name2, show1, show2) {
295+
function commonPrefix(name1?: any, name2?: any, show1?: any, show2?: any): any {
296296
// if only one is shown in the legend, use that
297297
if (show1 && !show2) return name1;
298298
if (show2 && !show1) return name2;
@@ -315,7 +315,7 @@ function commonPrefix(name1, name2, show1, show2) {
315315

316316
// textposition - support partial attributes (ie just 'top')
317317
// and incorrect use of middle / center etc.
318-
function cleanTextPosition(textposition) {
318+
function cleanTextPosition(textposition?: any): any {
319319
var posY = 'middle';
320320
var posX = 'center';
321321

@@ -330,11 +330,11 @@ function cleanTextPosition(textposition) {
330330
return posY + ' ' + posX;
331331
}
332332

333-
function emptyContainer(outer, innerStr) {
333+
function emptyContainer(outer?: any, innerStr?: any): any {
334334
return innerStr in outer && typeof outer[innerStr] === 'object' && Object.keys(outer[innerStr]).length === 0;
335335
}
336336

337-
export var swapXYData = function (trace) {
337+
export var swapXYData = function (trace?: any) {
338338
var i;
339339
swapAttrs(trace, ['?', '?0', 'd?', '?bins', 'nbins?', 'autobin?', '?src', 'error_?']);
340340
if (Array.isArray(trace.z) && Array.isArray(trace.z[0])) {
@@ -360,11 +360,11 @@ export var swapXYData = function (trace) {
360360
}
361361
};
362362

363-
export var coerceTraceIndices = function (gd, traceIndices) {
363+
export var coerceTraceIndices = function (gd?: any, traceIndices?: any) {
364364
if (isNumeric(traceIndices)) {
365365
return [traceIndices];
366366
} else if (!Array.isArray(traceIndices) || !traceIndices.length) {
367-
return gd.data.map(function (_, i) {
367+
return gd.data.map(function (_?: any, i?: any) {
368368
return i;
369369
});
370370
} else if (Array.isArray(traceIndices)) {
@@ -382,7 +382,7 @@ export var coerceTraceIndices = function (gd, traceIndices) {
382382
return traceIndices;
383383
};
384384

385-
export var manageArrayContainers = function (np, newVal, undoit) {
385+
export var manageArrayContainers = function (np?: any, newVal?: any, undoit?: any) {
386386
var obj = np.obj;
387387
var parts = np.parts;
388388
var pLength = parts.length;
@@ -424,12 +424,12 @@ export var manageArrayContainers = function (np, newVal, undoit) {
424424
*/
425425
var ATTR_TAIL_RE = /(\.[^\[\]\.]+|\[[^\[\]\.]+\])$/;
426426

427-
function getParent(attr) {
427+
function getParent(attr?: any): any {
428428
var tail = attr.search(ATTR_TAIL_RE);
429429
if (tail > 0) return attr.slice(0, tail);
430430
}
431431

432-
export var hasParent = function (aobj, attr) {
432+
export var hasParent = function (aobj?: any, attr?: any) {
433433
var attrParent = getParent(attr);
434434
while (attrParent) {
435435
if (attrParent in aobj) return true;
@@ -438,7 +438,7 @@ export var hasParent = function (aobj, attr) {
438438
return false;
439439
};
440440

441-
export var clearAxisTypes = function (gd, traces, layoutUpdate) {
441+
export var clearAxisTypes = function (gd?: any, traces?: any, layoutUpdate?: any) {
442442
for (var i = 0; i < traces.length; i++) {
443443
var trace = gd._fullData[i];
444444
for (var j = 0; j < 3; j++) {
Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -28,7 +28,7 @@ export var deleteFrames = main.deleteFrames;
2828
export var animate = main.animate;
2929
export var setPlotConfig = main.setPlotConfig;
3030

31-
export var deleteActiveShape = function(gd) {
31+
export var deleteActiveShape = function(gd?: any): any {
3232
return Registry.getComponentMethod('shapes', 'eraseActiveShape')(getGraphDiv(gd));
3333
};
3434

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -6,15 +6,15 @@ import Registry from '../registry.js';
66
import _req0 from './container_array_match.js';
77
export var containerArrayMatch = _req0;
88

9-
export var isAddVal = function isAddVal(val) {
9+
export var isAddVal = function isAddVal(val?: any): any {
1010
return val === 'add' || isPlainObject(val);
1111
};
1212

13-
export var isRemoveVal = function isRemoveVal(val) {
13+
export var isRemoveVal = function isRemoveVal(val?: any): any {
1414
return val === null || val === 'remove';
1515
};
1616

17-
export var applyContainerArrayChanges = function applyContainerArrayChanges(gd, np, edits, flags, _nestedProperty) {
17+
export var applyContainerArrayChanges = function applyContainerArrayChanges(gd?: any, np?: any, edits?: any, flags?: any, _nestedProperty?: any): any {
1818
var componentType = np.astr;
1919
var supplyComponentDefaults = Registry.getComponentMethod(componentType, 'supplyLayoutDefaults');
2020
var draw = Registry.getComponentMethod(componentType, 'draw');

0 commit comments

Comments
 (0)