apply real types to core files: GraphDiv, FullTrace, FullLayout, FullAxis

Replace `gd: any` → `gd: GraphDiv`, `trace: any` → `FullTrace`, etc.
in key files: subroutines.ts, fx/click.ts, fx/defaults.ts, fx/calc.ts,
drawing/index.ts. Fix schema.d.ts backslash escaping. Fix colorbar
calling tick_mark_defaults with wrong arg count. Fix BasePlotModule.plot
params to be optional.

Manual file-by-file edits (not scripted) for reliability.
tsc --noEmit: 0 errors.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

Author: ryan-williams

src/components/colorbar/defaults.ts

@@ -117,7 +117,7 @@ export default function colorbarDefaults(containerIn: any, containerOut: any, la
     }
     handlePrefixSuffixDefaults(colorbarIn, colorbarOut, coerce, 'linear', opts);
     handleTickLabelDefaults(colorbarIn, colorbarOut, coerce, 'linear', opts);
-    handleTickMarkDefaults(colorbarIn, colorbarOut, coerce, 'linear', opts);
+    handleTickMarkDefaults(colorbarIn, colorbarOut, coerce, opts);
 
     coerce('title.text', layout._dfltTitle.colorbar);
 

src/components/fx/click.ts

@@ -1,7 +1,8 @@
+import type { GraphDiv } from '../../../types/core';
 import Registry from '../../registry.js';
 import { hover } from './hover.js';
 
-export default function click(gd: any, evt: any, subplot?: any): void {
+export default function click(gd: GraphDiv, evt: MouseEvent, subplot?: string): void {
     var annotationsDone = Registry.getComponentMethod('annotations', 'onClick')(gd, gd._hoverdata);
 
     // fallback to fail-safe in case the plot type's hover method doesn't pass the subplot.

src/components/fx/defaults.ts

@@ -1,8 +1,9 @@
+import type { FullLayout, FullTrace, InputTrace } from '../../../types/core';
 import Lib, { extendFlat } from '../../lib/index.js';
 import attributes from './attributes.js';
 import handleHoverLabelDefaults from './hoverlabel_defaults.js';
 
-export default function supplyDefaults(traceIn: any, traceOut: any, defaultColor: any, layout: any): void {
+export default function supplyDefaults(traceIn: InputTrace, traceOut: FullTrace, defaultColor: string, layout: FullLayout): void {
     function coerce(attr: string, dflt?: any): any {
         return Lib.coerce(traceIn, traceOut, attributes, attr, dflt);
     }

src/plot_api/plot_api.ts

@@ -434,7 +434,7 @@ function _doPlot(gd?: any, data?: any, layout?: any, config?: any): any {
             requestAnimationFrame(function () {
                 performance.mark('plotly-deferredMargin-start');
 
-                var deferredSeq = [timedMarginPushers, marginPushersAgain];
+                var deferredSeq: any[] = [timedMarginPushers, marginPushersAgain];
                 if (hasCartesian) deferredSeq.push(positionAndAutorange);
                 deferredSeq.push(subroutines.layoutStyles);
                 if (hasCartesian) deferredSeq.push(drawAxes);

src/plot_api/subroutines.ts

@@ -1,4 +1,5 @@
 import { select } from 'd3-selection';
+import type { FullAxis, FullLayout, GraphDiv } from '../../types/core';
 import Registry from '../registry.js';
 import { allowAutoMargin, autoMargin, doAutoMargin, previousPromises, style } from '../plots/plots.js';
 import { ensureSingle, ensureSingleById, isBottomAnchor, isLeftAnchor, isMiddleAnchor, isRightAnchor, isTopAnchor, pushUnique, syncOrAsync } from '../lib/index.js';
@@ -21,7 +22,7 @@ var SVG_TEXT_ANCHOR_START = 'start';
 var SVG_TEXT_ANCHOR_MIDDLE = 'middle';
 var SVG_TEXT_ANCHOR_END = 'end';
 
-export var layoutStyles = function(gd?: any): any {
+export var layoutStyles = function(gd: GraphDiv): any {
     return syncOrAsync([doAutoMargin, lsInner], gd);
 };
 
@@ -40,8 +41,8 @@ function overlappingDomain(xDomain?: any, yDomain?: any, domains?: any): any {
     return false;
 }
 
-function lsInner(gd?: any): any {
-    var fullLayout: any = gd._fullLayout;
+function lsInner(gd: GraphDiv): any {
+    var fullLayout = gd._fullLayout;
     var gs = fullLayout._size;
     var pad = gs.p;
     var axList = Axes.list(gd, '', true);
@@ -400,9 +401,9 @@ function findCounterAxisLineWidth(ax?: any, side?: any, counterAx?: any, axList?
     return 0;
 }
 
-export var drawMainTitle = function(gd?: any): any {
+export var drawMainTitle = function(gd: GraphDiv): any {
     var title: any = gd._fullLayout.title;
-    var fullLayout: any = gd._fullLayout;
+    var fullLayout = gd._fullLayout;
     var textAnchor = getMainTitleTextAnchor(fullLayout);
     var dy = getMainTitleDy(fullLayout);
     var y = getMainTitleY(fullLayout, dy);
@@ -623,14 +624,14 @@ function getMainTitleDy(fullLayout?: any): any {
     return dy;
 }
 
-export var doTraceStyle = function(gd?: any): any {
+export var doTraceStyle = function(gd: GraphDiv): any {
     var calcdata = gd.calcdata;
     var editStyleCalls = [];
     var i;
 
     for(i = 0; i < calcdata.length; i++) {
         var cd = calcdata[i];
-        var cd0 = cd[0] || {};
+        var cd0: any = cd[0] || {};
         var trace: any = cd0.trace || {};
         var _module = trace._module || {};
 
@@ -660,23 +661,23 @@ export var doTraceStyle = function(gd?: any): any {
     return previousPromises(gd);
 };
 
-export var doColorBars = function(gd?: any): any {
+export var doColorBars = function(gd: GraphDiv): any {
     Registry.getComponentMethod('colorbar', 'draw')(gd);
     return previousPromises(gd);
 };
 
-export var layoutReplot = function(gd?: any): any {
+export var layoutReplot = function(gd: GraphDiv): any {
     var layout = gd.layout;
     gd.layout = undefined;
     return Registry.call('_doPlot', gd, '', layout);
 };
 
-export var doLegend = function(gd?: any): any {
+export var doLegend = function(gd: GraphDiv): any {
     Registry.getComponentMethod('legend', 'draw')(gd);
     return previousPromises(gd);
 };
 
-export var doTicksRelayout = function(gd?: any): any {
+export var doTicksRelayout = function(gd: GraphDiv): any {
     Axes.draw(gd, 'redraw');
 
     if(gd._fullLayout._hasOnlyLargeSploms) {
@@ -689,8 +690,8 @@ export var doTicksRelayout = function(gd?: any): any {
     return previousPromises(gd);
 };
 
-export var doModeBar = function(gd?: any): any {
-    var fullLayout: any = gd._fullLayout;
+export var doModeBar = function(gd: GraphDiv): any {
+    var fullLayout = gd._fullLayout;
 
     Registry.getComponentMethod('modebar', 'manage')(gd);
 
@@ -702,8 +703,8 @@ export var doModeBar = function(gd?: any): any {
     return previousPromises(gd);
 };
 
-export var doCamera = function(gd?: any): any {
-    var fullLayout: any = gd._fullLayout;
+export var doCamera = function(gd: GraphDiv): any {
+    var fullLayout = gd._fullLayout;
     var sceneIds = fullLayout._subplots.gl3d;
 
     for(var i = 0; i < sceneIds.length; i++) {
@@ -714,8 +715,8 @@ export var doCamera = function(gd?: any): any {
     }
 };
 
-export var drawData = function(gd?: any): any {
-    var fullLayout: any = gd._fullLayout;
+export var drawData = function(gd: GraphDiv): any {
+    var fullLayout = gd._fullLayout;
 
     clearGlCanvases(gd);
 
@@ -743,8 +744,8 @@ export var drawData = function(gd?: any): any {
     return previousPromises(gd);
 };
 
-export var redrawReglTraces = function(gd?: any): any {
-    var fullLayout: any = gd._fullLayout;
+export var redrawReglTraces = function(gd: GraphDiv): any {
+    var fullLayout = gd._fullLayout;
 
     if(fullLayout._has('regl')) {
         var fullData = gd._fullData;
@@ -786,7 +787,7 @@ export var redrawReglTraces = function(gd?: any): any {
     }
 };
 
-export var doAutoRangeAndConstraints = function(gd?: any): any {
+export var doAutoRangeAndConstraints = function(gd: GraphDiv): any {
     var axList = Axes.list(gd, '', true);
     var ax;
 
@@ -818,7 +819,7 @@ export var doAutoRangeAndConstraints = function(gd?: any): any {
     enforceAxisConstraints(gd);
 };
 
-export var finalDraw = function(gd?: any): any {
+export var finalDraw = function(gd: GraphDiv): any {
     // TODO: rangesliders really belong in marginPushers but they need to be
     // drawn after data - can we at least get the margin pushing part separated
     // out and done earlier?
@@ -830,7 +831,7 @@ export var finalDraw = function(gd?: any): any {
     Registry.getComponentMethod('rangeselector', 'draw')(gd);
 };
 
-export var drawMarginPushers = function(gd?: any): any {
+export var drawMarginPushers = function(gd: GraphDiv): any {
     Registry.getComponentMethod('legend', 'draw')(gd);
     Registry.getComponentMethod('rangeselector', 'draw')(gd);
     Registry.getComponentMethod('sliders', 'draw')(gd);

tasks/gen-schema-types.mjs

@@ -44,7 +44,7 @@ function valTypeToTS(attr) {
         case 'enumerated':
             if(attr.values) {
                 return attr.values.map(v => {
-                    if(typeof v === 'string') return `'${v}'`;
+                    if(typeof v === 'string') return `'${v.replace(/\\/g, '\\\\').replace(/'/g, "\\'")}'`;
                     if(typeof v === 'boolean') return String(v);
                     return String(v);
                 }).join(' | ');

types/core.d.ts

@@ -213,7 +213,7 @@ export interface TraceModule {
 export interface BasePlotModule {
     name: string;
     attr?: string[];
-    plot?: (gd: GraphDiv, plotinfo: PlotInfo, cdModule: CalcData[]) => void;
+    plot?: (gd: GraphDiv, plotinfo?: PlotInfo, cdModule?: CalcData[]) => void;
     drawFramework?: (gd: GraphDiv) => void;
     clean?: (newFullData: FullTrace[], newFullLayout: FullLayout, oldFullData: FullTrace[], oldFullLayout: FullLayout) => void;
     [key: string]: any;

types/schema.d.ts

@@ -54,7 +54,7 @@ export interface ScatterTrace {
         fgopacity?: number;
         fillmode?: 'replace' | 'overlay';
         path?: string;
-        shape?: '' | '/' | '\' | 'x' | '-' | '|' | '+' | '.';
+        shape?: '' | '/' | '\\' | 'x' | '-' | '|' | '+' | '.';
         size?: number;
         solidity?: number;
     };