Skip to content

Commit b5475df

Browse files
ryan-williamsclaude
andcommitted
fix: use namespace imports for CJS deps, inline \has-hover\
CJS dependencies imported with `import X from '...'` fail in Vite dev mode (no default export). Changed ~120 imports across ~95 files to use `import * as X from '...'` for CJS packages. Inlined `has-hover` (5-line package, unmaintained since 2016) to avoid its `global` reference that breaks in browsers. 🤖 Generated with [Claude Code](https://claude.com/claude-code) Co-Authored-By: Claude <noreply@anthropic.com>
1 parent d6fa2e0 commit b5475df

File tree

173 files changed

+275
-218
lines changed

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

173 files changed

+275
-218
lines changed

specs/done/esm-cjs-interop.md

Lines changed: 37 additions & 0 deletions

specs/done/global-shim.md

Lines changed: 20 additions & 0 deletions

src/components/annotations/convert_coords.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import isNumeric from 'fast-isnumeric';
1+
import * as isNumeric from 'fast-isnumeric';
22
import toLogRange from '../../lib/to_log_range.js';
33

44
export default function convertCoords(gd, ax, newType, doExtra) {

src/components/annotations/draw.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import d3 from '@plotly/d3';
1+
import * as d3 from '@plotly/d3';
22
import Registry from '../../registry.js';
33
import Plots from '../../plots/plots.js';
44
import Lib from '../../lib/index.js';

src/components/annotations/draw_arrow_head.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import d3 from '@plotly/d3';
1+
import * as d3 from '@plotly/d3';
22
import Color from '../color/index.js';
33
import ARROWPATHS from './arrow_paths.js';
44
import Lib from '../../lib/index.js';

src/components/calendars/calendars.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import worldCalendars from 'world-calendars/dist/main';
1+
import * as worldCalendars from 'world-calendars/dist/main';
22
import 'world-calendars/dist/plus';
33
import 'world-calendars/dist/calendars/chinese';
44
import 'world-calendars/dist/calendars/coptic';

src/components/color/index.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import tinycolor from 'tinycolor2';
2-
import isNumeric from 'fast-isnumeric';
1+
import * as tinycolor from 'tinycolor2';
2+
import * as isNumeric from 'fast-isnumeric';
33
import { isTypedArray } from '../../lib/array.js';
44
import colorAttrs from './attributes.js';
55

src/components/colorbar/draw.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -1,5 +1,5 @@
1-
import d3 from '@plotly/d3';
2-
import tinycolor from 'tinycolor2';
1+
import * as d3 from '@plotly/d3';
2+
import * as tinycolor from 'tinycolor2';
33
import Plots from '../../plots/plots.js';
44
import Registry from '../../registry.js';
55
import Axes from '../../plots/cartesian/axes.js';

src/components/colorscale/calc.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import isNumeric from 'fast-isnumeric';
1+
import * as isNumeric from 'fast-isnumeric';
22
import Lib from '../../lib/index.js';
33
import _helpers from './helpers.js';
44
const { extractOpts } = _helpers;

src/components/colorscale/defaults.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,4 +1,4 @@
1-
import isNumeric from 'fast-isnumeric';
1+
import * as isNumeric from 'fast-isnumeric';
22
import Lib from '../../lib/index.js';
33
import hasColorbar from '../colorbar/has_colorbar.js';
44
import colorbarDefaults from '../colorbar/defaults.js';

0 commit comments

Comments
 (0)