Skip to content

Commit 6f105f2

Browse files
committed
Set default log level to INFO instead of ERROR
- Update Logger class default from ERROR to INFO - Update pyodide runtime agent log level parsing defaults - Ensure INFO is used when RUNT_LOG_LEVEL environment variable is not set - Matches documented behavior that default is INFO - Tests continue to explicitly set ERROR level so remain unaffected
1 parent 406b9d3 commit 6f105f2

File tree

3 files changed

+11
-5
lines changed

3 files changed

+11
-5
lines changed

packages/lib/src/logging.ts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -37,7 +37,7 @@ export interface LoggerConfig {
3737
*/
3838
class Logger {
3939
private config: LoggerConfig = {
40-
level: LogLevel.ERROR,
40+
level: LogLevel.INFO,
4141
console: true,
4242
service: "runt-agent",
4343
};

packages/pyodide-runtime-agent/src/mod.ts

Lines changed: 7 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -40,13 +40,19 @@ if (import.meta.main) {
4040
logLevel = LogLevel.ERROR;
4141
break;
4242
default:
43-
logLevel = LogLevel.ERROR;
43+
logLevel = LogLevel.INFO;
4444
}
4545

4646
logger.configure({
4747
level: logLevel,
4848
console: !disableConsole,
4949
});
50+
} else {
51+
// Configure with INFO as default when no RUNT_LOG_LEVEL is set
52+
logger.configure({
53+
level: LogLevel.INFO,
54+
console: !disableConsole,
55+
});
5056
}
5157

5258
logger.info("Authenticating...");

packages/pyodide-runtime-agent/src/pyodide-agent.ts

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -98,7 +98,7 @@ export class PyodideRuntimeAgent extends RuntimeAgent {
9898
* Parse log level from environment variable string
9999
*/
100100
private parseLogLevel(levelStr: string | undefined): LogLevel {
101-
if (!levelStr) return LogLevel.ERROR;
101+
if (!levelStr) return LogLevel.INFO;
102102

103103
const normalizedLevel = levelStr.toUpperCase();
104104
switch (normalizedLevel) {
@@ -112,7 +112,7 @@ export class PyodideRuntimeAgent extends RuntimeAgent {
112112
case "ERROR":
113113
return LogLevel.ERROR;
114114
default:
115-
return LogLevel.ERROR;
115+
return LogLevel.INFO;
116116
}
117117
}
118118

@@ -180,7 +180,7 @@ export class PyodideRuntimeAgent extends RuntimeAgent {
180180
// Configure logger from environment variables early if not already configured
181181
// This ensures RUNT_LOG_LEVEL is respected even when using PyodideRuntimeAgent programmatically
182182
if (
183-
Deno.env.get("RUNT_LOG_LEVEL") && logger.getLevel() === LogLevel.ERROR
183+
Deno.env.get("RUNT_LOG_LEVEL") && logger.getLevel() === LogLevel.INFO
184184
) {
185185
this.configureLoggerFromEnvironment();
186186
}

0 commit comments

Comments
 (0)