Use more general trait for message

Author: raphjaph

Cargo.lock

@@ -20,4 +20,4 @@ snafu = { version =  "0.8.5", default-features = false, features = ["rust_1_61",
 [dev-dependencies]
 hex = "0.4.3"
 pretty_assertions = "1.4.1"
-rand = "0.8.5"
+rand = "0.9.0"

Cargo.toml

@@ -66,7 +66,7 @@ mod tests {
     assert_eq!(
       create_to_spend(
         &Address::from_str(SEGWIT_ADDRESS).unwrap().assume_checked(),
-        "".as_bytes()
+        ""
       )
       .unwrap()
       .compute_txid()
@@ -77,7 +77,7 @@ mod tests {
     assert_eq!(
       create_to_spend(
         &Address::from_str(SEGWIT_ADDRESS).unwrap().assume_checked(),
-        "Hello World".as_bytes()
+        "Hello World"
       )
       .unwrap()
       .compute_txid()
@@ -90,7 +90,7 @@ mod tests {
   fn to_sign_txids_correct() {
     let to_spend = create_to_spend(
       &Address::from_str(SEGWIT_ADDRESS).unwrap().assume_checked(),
-      "".as_bytes(),
+      "",
     )
     .unwrap();
 
@@ -103,7 +103,7 @@ mod tests {
 
     let to_spend = create_to_spend(
       &Address::from_str(SEGWIT_ADDRESS).unwrap().assume_checked(),
-      "Hello World".as_bytes(),
+      "Hello World",
     )
     .unwrap();
 
@@ -338,13 +338,13 @@ mod tests {
   #[test]
   fn adding_aux_randomness_roundtrips() {
     let address = Address::from_str(TAPROOT_ADDRESS).unwrap().assume_checked();
-    let message = "Hello World with aux randomness".as_bytes();
+    let message = "Hello World with aux randomness";
     let to_spend = create_to_spend(&address, message).unwrap();
     let to_sign = create_to_sign(&to_spend, None).unwrap();
     let private_key = PrivateKey::from_wif(WIF_PRIVATE_KEY).unwrap();
 
     let mut aux_rand = [0u8; 32];
-    rand::thread_rng().fill_bytes(&mut aux_rand);
+    rand::rng().fill_bytes(&mut aux_rand);
 
     let witness =
       create_message_signature_taproot(&to_spend, &to_sign, private_key, Some(aux_rand));

src/lib.rs

@@ -8,7 +8,7 @@ pub fn sign_simple_encoded(address: &str, message: &str, wif_private_key: &str)
 
   let private_key = PrivateKey::from_wif(wif_private_key).context(error::PrivateKeyParse)?;
 
-  let witness = sign_simple(&address, message.as_bytes(), private_key)?;
+  let witness = sign_simple(&address, message, private_key)?;
 
   let mut buffer = Vec::new();
 
@@ -27,7 +27,7 @@ pub fn sign_full_encoded(address: &str, message: &str, wif_private_key: &str) ->
 
   let private_key = PrivateKey::from_wif(wif_private_key).context(error::PrivateKeyParse)?;
 
-  let tx = sign_full(&address, message.as_bytes(), private_key)?;
+  let tx = sign_full(&address, message, private_key)?;
 
   let mut buffer = Vec::new();
 
@@ -38,7 +38,11 @@ pub fn sign_full_encoded(address: &str, message: &str, wif_private_key: &str) ->
 }
 
 /// Signs in the BIP-322 simple format from proper Rust types and returns the witness.
-pub fn sign_simple(address: &Address, message: &[u8], private_key: PrivateKey) -> Result<Witness> {
+pub fn sign_simple(
+  address: &Address,
+  message: impl AsRef<[u8]>,
+  private_key: PrivateKey,
+) -> Result<Witness> {
   Ok(
     sign_full(address, message, private_key)?.input[0]
       .witness
@@ -49,7 +53,7 @@ pub fn sign_simple(address: &Address, message: &[u8], private_key: PrivateKey) -
 /// Signs in the BIP-322 full format from proper Rust types and returns the full transaction.
 pub fn sign_full(
   address: &Address,
-  message: &[u8],
+  message: impl AsRef<[u8]>,
   private_key: PrivateKey,
 ) -> Result<Transaction> {
   let to_spend = create_to_spend(address, message)?;

src/sign.rs

@@ -14,7 +14,7 @@ pub fn tagged_hash(tag: &str, message: impl AsRef<[u8]>) -> [u8; 32] {
 }
 
 /// Create the `to_spend` transaction.
-pub fn create_to_spend(address: &Address, message: &[u8]) -> Result<Transaction> {
+pub fn create_to_spend(address: &Address, message: impl AsRef<[u8]>) -> Result<Transaction> {
   Ok(Transaction {
     version: Version(0),
     lock_time: LockTime::ZERO,