Fee rate units

[tcharding]

The Core RPC API is not consistent with the unit used for fee rates. I can't remember if it changes between versions or between methods but sometimes its BTC/kB and sometimes its satoshis per virtual byte. Fortunately these are different types (f64 and u64 respectively).

However, in the ecosystem, fee rates are also measured in sats per kilo weight unit. Both sats per vb and sats per kwu use u64 - we should make some effort to ensure that Core does not use both and that we are not mixing these up.

Perhaps #58 will help with this if we are checking values returned.

[GideonBature]

It changes between versions as well as methods, although for versions, from version 21 downwards methods like estimatesmartfee and settxfee makes use of BTC/vB while from version 22 upwards, same methods makes use of BTC/kvB.

While between methods, for same feerate, bumpfee and psbtbumpfee makes use of sat/vB compared to estimatesmartfee and settxfee that makes use of BTC/kvB or BTC/vB.

Hopefully, just like you mentioned, resolving issue #58 will also help solve this issue.