Commit b3b53ea
committed
fix: clippy tokio-rich feature set (used_underscore_binding, ignored_unit_patterns)
The 'clippy (tokio-rich)' job exercises the non-compio feature
combination and tripped over two lints not caught by the previous
batch:
- `tako-core/src/client.rs`: the `_conn_handle` field on
TakoClient/TakoTlsClient was originally underscore-prefixed to
signal 'unused' to the compiler, but CB21 added a Drop impl that
calls `self._conn_handle.abort()` — the binding IS used now, so
clippy correctly complains. Rename to `conn_handle` (no underscore)
and switch the two struct-literal sites to shorthand.
- `tako-core/src/signals.rs`: the `#[cfg(not(feature = "compio"))]`
branch of subscribe_filtered also had `Ok(_) => {}` — the previous
fix only caught the compio branch. Both branches now use
`Ok(()) => {}` for symmetry.1 parent aaeffb5 commit b3b53ea
2 files changed
Lines changed: 8 additions & 8 deletions
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
341 | 341 | | |
342 | 342 | | |
343 | 343 | | |
344 | | - | |
| 344 | + | |
345 | 345 | | |
346 | 346 | | |
347 | 347 | | |
| |||
384 | 384 | | |
385 | 385 | | |
386 | 386 | | |
387 | | - | |
| 387 | + | |
388 | 388 | | |
389 | 389 | | |
390 | 390 | | |
| |||
446 | 446 | | |
447 | 447 | | |
448 | 448 | | |
449 | | - | |
| 449 | + | |
450 | 450 | | |
451 | 451 | | |
452 | 452 | | |
453 | 453 | | |
454 | | - | |
| 454 | + | |
455 | 455 | | |
456 | 456 | | |
457 | 457 | | |
| |||
498 | 498 | | |
499 | 499 | | |
500 | 500 | | |
501 | | - | |
| 501 | + | |
502 | 502 | | |
503 | 503 | | |
504 | 504 | | |
| |||
529 | 529 | | |
530 | 530 | | |
531 | 531 | | |
532 | | - | |
| 532 | + | |
533 | 533 | | |
534 | 534 | | |
535 | 535 | | |
| |||
594 | 594 | | |
595 | 595 | | |
596 | 596 | | |
597 | | - | |
| 597 | + | |
598 | 598 | | |
599 | 599 | | |
| Original file line number | Diff line number | Diff line change | |
|---|---|---|---|
| |||
452 | 452 | | |
453 | 453 | | |
454 | 454 | | |
455 | | - | |
| 455 | + | |
456 | 456 | | |
457 | 457 | | |
458 | 458 | | |
| |||
0 commit comments