Skip to content

Delegate Cargo.toml style guide to style team? #13313

Open
@joshtriplett

Description

@joshtriplett

@rust-lang/cargo previously discussed the possibility of formatting Cargo.toml. There are open questions around that, such as whether rustfmt or cargo fmt is responsible for doing the formatting.

This issue is to determine who has the responsibility for writing and maintaining the style guide for Cargo.toml. The old style team (years ago) did write a style guide for Cargo.toml manifests, but there was never any automated tooling to format manifests according to that style, so we don't want to presume that that style is well-established.

When this came up previously, cargo had at least one concern with the current style guidance, which I'm addressing with this PR: rust-lang/rust#120072 . Currently reviewing other potential concerns, and will post fixes for those as well, before the style guide gets used for any form of automatic formatting.

With my Cargo team hat on, I would propose that the Cargo team delegate responsibility for bikeshedding writing and maintaining the style guide for Cargo.toml manifest to the style team, with the understanding that:

  • The Cargo team can always raise objections if there's style guidance they have concerns with
  • The Cargo team can withdraw the delegation if they have unresolved concerns with how that work is being done

Metadata

Metadata

Assignees

No one assigned

    Labels

    S-triageStatus: This issue is waiting on initial triage.T-cargoTeam: Cargodisposition-mergeFCP with intent to mergeproposed-final-comment-periodAn FCP proposal has started, but not yet signed off.

    Type

    No type

    Projects

    Status

    FCP blocked

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions