Profiles for non root package

[Ghamza-Jd]

Problem

I want to change the default release profile to optimize for size. If I set the profile in a workspace member package it logs this warning:

warning: profiles for the non root package will be ignored, specify profiles at the workspace root

So I've moved the profile to the root package but it didn't take any effect (size went from 48 MBs to 88 MBs)

And if I have the profile in both, it does ignore the non root one so no issue in their.

Summary: non root packages are ignoring the profile from the root package

Steps

No response

Possible Solution(s)

No response

Notes

No response

Version

[ehuss]

Can you please include a complete reproduction? It's not clear what the issue here is from the description.

[Ghamza-Jd]

Can you please include a complete reproduction? It's not clear what the issue here is from the description.

Sure, the repo I'm working on is: https://github.com/Ghamza-Jd/janus-mobile-sdk

Currently the release profile config is inside rslib/Cargo.toml, if we run cargo run -p rslib --release the size of the static lib .a is 39 MB and for the .rlib its 7.2 MB

But if you move the config to the root Cargo.toml and rerun cargo run -p rslib --release the size of the static lib .a is 75 MB and the .rlib is 13.1 MB

So the configs aren't being used when they're in the root package

[ehuss]

I believe it is working correctly when the profile is moved to the workspace. lto = "thin" can result in substantially larger binaries due to inlining.

You can use the --verbose flag to verify which flags are being passed to rustc.

[epage]

Note that for cargo install from a registry, the workspace profile will be lost. We are tracking that in #8264