Is there a reason `__set_env` is hidden?

[oconnor663]

As of edition 2024, it's unsafe for build scripts to set environment variables the old fashioned way, so a safe way to set them on Commands spawned inside the Build would be very useful. It looks like the __set_env method does exactly this, but there must be a reason it's hidden?

[NobodyXu]

Previously it's meant to only used for test, hence why it's hidden and start with __

I think it's better if we add a set_env there?

[oconnor663]

Oh for sure, if we were going to make it public, we'd want to remove the leading underscores too. But mainly I'm surprised no one has asked for it yet, and I assumed I was missing something :)

[NobodyXu]

we'd want to remove the leading underscores too.

I think we'd want to keep __set_env just to avoid breaking semver.

No one should use it but someone could be

But mainly I'm surprised no one has asked for it yet, and I assumed I was missing something :)

Nah, do you want to open a PR for this? I'd happily merge it