Skip to content

Fix/upgrade Chalk in wake of librarifying Copy/Clone on arrays and reinstate test #758

Open
@bstrie

Description

@bstrie

Prior to rust-lang/rust#86041 , Copy and Clone are implemented on arrays by way of compiler magic. Now that const generics exist, these magical impls can be converted to proper library impls. Changes to trait selection were necessary to make this happen. However, rustc's test suite also contains some tests for rustc's next-gen trait selection engine, Chalk, one of which no longer passes in the presence of the new library impls. Because Chalk lives out of tree, rust-lang/rust#86041 has no way to fix this other than performing a complete Chalk upgrade, which would be a broad undertaking that is out of scope for the PR. Instead, after asking in the #wg-traits channel ( https://rust-lang.zulipchat.com/#narrow/stream/144729-wg-traits/topic/chalk.20ICE.20in.20rustc.20tests ), the decision was made to comment out the offending line until such time as Chalk is properly fixed and rustc has upgraded its dependency.

(Note: as of this writing rust-lang/rust#86041 is still open, but I've filed this now in order to have an issue number to put in the FIXME comment.)

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-chalk-solveIssues related to the chalk-solve crate

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions