You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: src/dev-guide.rst
+24Lines changed: 24 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -96,6 +96,30 @@ Use the following sentence pattern for multiple syntax categories::
96
96
97
97
``<Action>`` must denote either ``Changed``, ``New``, or ``Removed``.
98
98
99
+
Dealing with PR blockers
100
+
------------------------
101
+
102
+
Incorrect or incomplete semantics
103
+
~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
104
+
105
+
While working on a PR, a developer may need to modify existing FLS semantics or terminology, only for the developer to discover that these semantics or terms are either incorrect or incomplete.
106
+
In such cases, bring up the issue during one of the FLS team meetings.
107
+
108
+
Depending on the scope of the required changes, the FLS team may decide to either:
109
+
- Enact the necessary changes in the same PR-in-development, or
110
+
- Approximate the contents of the PR-in-development, and open a GitHub issue to track the update on the semantics or terms.
111
+
112
+
Missing semantics
113
+
~~~~~~~~~~~~~~~~~
114
+
115
+
While working on a PR, a developer may need to modify existing FLS semantics or use existing terminology, only for the developer to discover that these semantics or terms are missing.
116
+
This may happen when the Rust Reference or other sources the FLS team may use as reference were changed irrespective of Rust releases.
117
+
In such cases, bring up the issue during one of the FLS team meetings.
118
+
119
+
Depending on the scope of the required changes, the FLS team may decide to either:
120
+
- Enact the necessary changes in the same PR, or
121
+
- Create a separate PR to introduce the missing semantics or terms, and then update the contents of the PR-in-development.
0 commit comments