ui tests have strange names on Windows hosts

[RalfJung]

On Windows hosts, our ui tests have names like this:

  tests/pass\function_calls\exported_symbol.rs ... ok
  tests/pass\concurrency\windows_condvar_shared.rs ... ok
  tests/pass\issues\issue-15063.rs ... ok
  tests/pass\issues\issue-15080.rs ... ok

This mix of forward and backward slashes is definitely a bug.^^ Not sure which one it should be, but it'd be nice if filtering for pass-dep/shim worked on all platforms, so maybe it should be / everywhere?

[RalfJung]

Triage: it still looks like this

  tests/pass\align.rs ... ok
  tests/pass\align_repeat_into_packed_field.rs ... ok
  tests/pass\align_repeat_into_well_aligned_array.rs ... ok
  tests/pass\align_strange_enum_discriminant_offset.rs ... ok

@oli-obk any idea where in ui_test those backslashes are coming from -- and why it's a mix of forward slashes and backslashes?

[oli-obk]

I forgot about those because I was lazy and normalized them away in dogfood tests.

Getting them all to be slashes is annoying, because the PathBuf APIs use platform folder separators, so we end up with backslashes on windows when using push instead of manually building the path as a string and using PathBuf::from

[RalfJung]

If they all become \ on Windows that would also make sense. I guess the slashes come from here?

Do filters normalize to /, i.e., will pass/align work as a filter on Windows?

[oli-obk]

Do filters normalize to /, i.e., will pass/align work as a filter on Windows?

no, filters work on the display representation that you see.

guess the slashes come from here?

yes, to my surprise PathBuf::new("foo/bar") does not normalize the slashes

[RalfJung]

CI relies on tests/pass to work as a filter on Windows, so we'd have to change filter behavior if we wanted to render this as \.

Or we just define a "display" function on tests that replaces \ by /, and also use that for filtering. 🤷

[oli-obk]

Or we just define a "display" function on tests that replaces \ by /, and also use that for filtering.

yea I think I'm gonna do that on the ui_test side