Merge pull request #518 from folkertdev/test-float-f16

run `f16` float tests

Author: programmerjake

Cargo.lock

@@ -1,4 +1,5 @@
 #![feature(portable_simd)]
+#![feature(f16)]
 
 macro_rules! unary_test {
     { $scalar:tt, $($func:tt),+ } => {
@@ -86,5 +87,6 @@ macro_rules! impl_tests {
     }
 }
 
+impl_tests! { f16 }
 impl_tests! { f32 }
 impl_tests! { f64 }

crates/std_float/tests/float.rs

@@ -6,4 +6,3 @@ publish = false
 
 [dependencies]
 proptest = { workspace = true, features = ["alloc", "std"] }
-float-cmp = "0.10"

crates/test_helpers/Cargo.toml

@@ -1,7 +1,5 @@
 //! Compare numeric types approximately.
 
-use float_cmp::Ulps;
-
 pub trait ApproxEq {
     fn approxeq(&self, other: &Self, _ulps: i64) -> bool;
     fn fmt(&self, f: &mut core::fmt::Formatter) -> core::fmt::Result;
@@ -43,7 +41,14 @@ macro_rules! impl_float_approxeq {
                 if self.is_nan() && other.is_nan() {
                     true
                 } else {
-                    (self.ulps(other) as i64).abs() <= ulps
+                    let allowed_ulp_diff = ulps;
+
+                    // Approximate the ULP by taking half the distance between the number one place "up"
+                    // and the number one place "down".
+                    let ulp = (other.next_up() - other.next_down()) / 2.0;
+                    let ulp_diff = ((self - other) / ulp).abs().round() as i64;
+
+                    ulp_diff <= allowed_ulp_diff
                 }
             }
 
@@ -55,7 +60,7 @@ macro_rules! impl_float_approxeq {
     };
 }
 
-impl_float_approxeq! { f32, f64 }
+impl_float_approxeq! { f16, f32, f64 }
 
 impl<T: ApproxEq, const N: usize> ApproxEq for [T; N] {
     fn approxeq(&self, other: &Self, ulps: i64) -> bool {