Skip to content

Commit 703d7d8

Browse files
committed
Borrow more test cases
1 parent b7224f5 commit 703d7d8

2 files changed

Lines changed: 28 additions & 4 deletions

File tree

tests/ui/duration_suboptimal_units.fixed

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,29 @@ fn main() {
2323
let dur = Duration::from_secs(42);
2424
let dur = Duration::from_hours(3);
2525

26-
let dur = Duration::from_secs(60);
2726
let dur = Duration::from_mins(1);
2827
//~^ duration_suboptimal_units
28+
29+
// Literals with small promoted values should not lint (issue #16532)
30+
let dur = Duration::from_secs(60);
2931
let dur = Duration::from_secs(180);
32+
let dur = Duration::from_secs(180);
33+
let dur = Duration::from_millis(5_000);
34+
let dur = Duration::from_millis(1_000);
35+
let dur = Duration::from_secs(3_600);
36+
37+
// Literals with larger promoted values should lint
38+
let dur = Duration::from_secs(20);
39+
//~^ duration_suboptimal_units
40+
let dur = Duration::from_hours(12);
41+
//~^ duration_suboptimal_units
42+
3043
let dur = Duration::from_mins(3);
3144
//~^ duration_suboptimal_units
3245
let dur = Duration::from_mins(10);
3346
//~^ duration_suboptimal_units
3447
let dur = Duration::from_hours(24);
3548
//~^ duration_suboptimal_units
36-
let dur = Duration::from_millis(5_000);
3749
let dur = Duration::from_secs(5);
3850
//~^ duration_suboptimal_units
3951
let dur = Duration::from_hours(13);

tests/ui/duration_suboptimal_units.rs

Lines changed: 14 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -23,17 +23,29 @@ fn main() {
2323
let dur = Duration::from_secs(42);
2424
let dur = Duration::from_hours(3);
2525

26-
let dur = Duration::from_secs(60);
2726
let dur = Duration::from_secs(59 + 1);
2827
//~^ duration_suboptimal_units
28+
29+
// Literals with small promoted values should not lint (issue #16532)
30+
let dur = Duration::from_secs(60);
2931
let dur = Duration::from_secs(180);
32+
let dur = Duration::from_secs(180);
33+
let dur = Duration::from_millis(5_000);
34+
let dur = Duration::from_millis(1_000);
35+
let dur = Duration::from_secs(3_600);
36+
37+
// Literals with larger promoted values should lint
38+
let dur = Duration::from_millis(20_000);
39+
//~^ duration_suboptimal_units
40+
let dur = Duration::from_mins(720);
41+
//~^ duration_suboptimal_units
42+
3043
let dur = Duration::from_secs(60 * 3);
3144
//~^ duration_suboptimal_units
3245
let dur = Duration::from_secs(10 * 60);
3346
//~^ duration_suboptimal_units
3447
let dur = Duration::from_mins(24 * 60);
3548
//~^ duration_suboptimal_units
36-
let dur = Duration::from_millis(5_000);
3749
let dur = Duration::from_millis(5 * 1000);
3850
//~^ duration_suboptimal_units
3951
let dur = Duration::from_nanos(13 * 60 * 60 * 1_000 * 1_000 * 1_000);

0 commit comments

Comments
 (0)