perf: optimize sugg

Author: ArhanChaudhary

clippy_lints/src/nonnull_unchecked_on_box_ptr.rs

@@ -1,5 +1,5 @@
 use clippy_config::Conf;
-use clippy_utils::diagnostics::span_lint_and_sugg;
+use clippy_utils::diagnostics::span_lint_and_then;
 use clippy_utils::msrvs::{self, Msrv};
 use clippy_utils::res::{MaybeDef, MaybeQPath};
 use clippy_utils::source::snippet_with_context;
@@ -75,22 +75,23 @@ impl<'tcx> LateLintPass<'tcx> for NonnullUncheckedOnBoxPtr {
                 _ => expr.span,
             };
 
-            let mut app = Applicability::MachineApplicable;
-            let arg_name = snippet_with_context(cx, arg.span, ctxt, "_", &mut app).0;
-            let sugg = if self.msrv.meets(cx, msrvs::NONNULL_FROM_MUT) {
-                format!("NonNull::from_mut(Box::leak({arg_name}))")
-            } else {
-                format!("NonNull::from(Box::leak({arg_name}))")
-            };
-
-            span_lint_and_sugg(
+            span_lint_and_then(
                 cx,
                 NONNULL_UNCHECKED_ON_BOX_PTR,
                 span,
                 "use of `NonNull::new_unchecked` with `Box::into_raw`",
-                "try",
-                sugg,
-                app,
+                |diag| {
+                    let mut app = Applicability::MachineApplicable;
+                    let arg_name = snippet_with_context(cx, arg.span, ctxt, "_", &mut app).0;
+
+                    let sugg = if self.msrv.meets(cx, msrvs::NONNULL_FROM_MUT) {
+                        format!("NonNull::from_mut(Box::leak({arg_name}))")
+                    } else {
+                        format!("NonNull::from(Box::leak({arg_name}))")
+                    };
+
+                    diag.span_suggestion(span, "try", sugg, app);
+                },
             );
         }
     }