failed to automatically apply fixes suggested by rustc to crate `riscv_emu_rust`

[tommythorn]

Summary

$ git clone git@github.com:tommythorn/riscv-rust
$ cd riscv-rust
$ git reset --hard 03cefacbf
$ cargo clippy --fix
    Checking riscv_emu_rust v0.2.0 (..../riscv-rust)
warning: failed to automatically apply fixes suggested by rustc to crate `riscv_emu_rust`
...
and we would appreciate a bug report!

Version

rustc 1.84.1 (e71f9a9a9 2025-01-27)
binary: rustc
commit-hash: e71f9a9a98b0faf423844bf0ba7438f29dc27d58
commit-date: 2025-01-27
host: aarch64-apple-darwin
release: 1.84.1
LLVM version: 19.1.5

Note, this also reproduces with:
rustc 1.86.0-nightly (8239a37f9 2025-02-01)
binary: rustc
commit-hash: 8239a37f9c0951a037cfc51763ea52a20e71e6bd
commit-date: 2025-02-01
host: aarch64-apple-darwin
release: 1.86.0-nightly
LLVM version: 19.1.7

Error output

N/A

[tommythorn]

The full output of clippy:
error.txt

[tommythorn]

I think it boils down to this: Clippy changed get_page_address to const and changed the casts to u64::from(..) but the resulting

    const fn get_page_address(&self) -> u64 {
        u64::from(self.queue_pfn) * u64::from(self.guest_page_size)
    }

isn't legal because

cannot call non-const fn `<u64 as From<u64>>::from` in constant functions

(why not?)

[profetia]

Reproducer: https://play.rust-lang.org/?version=stable&mode=debug&edition=2024&gist=b4437cc3f8f1be1358176379fb25b051

Looks like the fix for missing_const_for_fn and cast_lossless got into conflict.