fix: collapsible_match suggests ref/derefs when needed
#14221
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rustbot
added
the
S-waiting-on-review
vishruth-thimmaiah
force-pushed
the
fix_collapsible_match_ref
branch
from
281a540 to
56abdc6
Compare
This comment has been minimized.
This comment has been minimized.
rustbot
added
S-waiting-on-author
|
Checking in here. It looks to me like the state is wrong now. Aren't we actually waiting on review? |
|
We are expecting both a review and a rebase. The bot settings have been changed a few days ago to let the PR in review state, so I'll reset it. @rustbot review |
rustbot
added
S-waiting-on-review
vishruth-thimmaiah
force-pushed
the
fix_collapsible_match_ref
branch
2 times, most recently
from
bc85de9 to
0dc1cdc
Compare
samueltardieu
requested changes
Apr 9, 2025
There was a problem hiding this comment.
It looks like you ignore the fact that the reference might be mutable. The following code will suggest using .as_ref():
let mut arr = ["a", "b", "c"];
if let Some(mut last) = arr.last_mut() {
match &mut last {
&mut &mut "a" | &mut &mut "b" => {
unimplemented!()
},
_ => (),
}
}The suggestion might also be incorrect in case of raw references, where the types may not match (untested):
const NULL_PTR: *const &'static str = std::ptr::null();
if let Some(last) = arr.last() {
match &raw const *last {
NULL_PTR => unimplemented!(),
_ => (),
}
}
vishruth-thimmaiah
force-pushed
the
fix_collapsible_match_ref
branch
from
0dc1cdc to
6116061
Compare
|
I couldn't figure out any way to handle |
vishruth-thimmaiah
force-pushed
the
fix_collapsible_match_ref
branch
from
6116061 to
3efde9f
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #14155
If an expression is borrowed/dereferenced, suggest using
.as_ref()or.copied()respectively in the outer conditional statement.changelog: [
collapsible_match] suggests ref/dereferencing when needed.