Skip to content

unnecessary_safety_comment does not lint for "orphan" comments #14556

Open
@ojeda

Description

@ojeda

Summary

unnecessary_safety_comment does not lint for "orphan" comments, i.e. the last (or only) comment.

Possibly related: #14553.
Possibly related: #14554.
Possibly related: #14555.

Lint Name

unnecessary_safety_comment

Reproducer

https://godbolt.org/z/GrjxKc9nW

I tried this code:

// This line should avoid #14553.

mod x {}

// SAFETY: ...

I expected to see this happen: lint.

Instead, this happened: no lint.

Same if it is a single comment:

// This line should avoid #14553.

// SAFETY: ...

Version

rustc 1.86.0 (05f9846f8 2025-03-31)
rustc 1.88.0-nightly (17ffbc81a 2025-04-04)

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-bugCategory: Clippy is not doing the correct thingI-false-negativeIssue: The lint should have been triggered on code, but wasn't

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions