Skip to content

Fix needless_for_each suggests wrongly when closure has no braces #14735

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Fix needless_for_each suggests wrongly when closure has no braces #14735

wants to merge 1 commit into from

Conversation

profetia
Copy link
Contributor

@profetia profetia commented May 5, 2025 •
edited by rustbot
Loading

Closes #14734

changelog: [needless_for_each] wrong suggestions when closure has no braces

@rustbot
Copy link
Collaborator

rustbot commented May 5, 2025

r? @blyxyas

rustbot has assigned @blyxyas.
They will have a look at your PR within the next two weeks and either review your PR or reassign to another reviewer.

Use r? to explicitly pick a reviewer

@rustbot rustbot added the S-waiting-on-review Status: Awaiting review from the assignee but also interested parties label May 5, 2025
@profetia profetia force-pushed the issue14734 branch 2 times, most recently from a326cfd to 500bc9f Compare May 6, 2025 07:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@blyxyas blyxyas blyxyas left review comments

Assignees

@blyxyas blyxyas

Labels
S-waiting-on-review Status: Awaiting review from the assignee but also interested parties
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Missing { … } for needless_for_each
3 participants
@profetia @rustbot @blyxyas