Skip to content

Commit 9fbd1f4

Browse files
jieyouxujieyouxu
committed
[DO NOT MERGE] bootstrap: skip some tests that fail on specific jobs
1 parent ab91dcc commit 9fbd1f4

File tree

1 file changed

+250
-4
lines changed
  • src/bootstrap/src/core/build_steps

1 file changed

+250
-4
lines changed

‎src/bootstrap/src/core/build_steps/test.rs

+250-4
Original file line numberDiff line numberDiff line change
@@ -1,3 +1,4 @@
1+
// ignore-tidy-filelength
12
//! Build-and-run steps for `./x.py test` test fixtures
23
//!
34
//! `./x.py test` (aka [`Kind::Test`]) is currently allowed to reach build steps in other modules.
@@ -409,12 +410,257 @@ impl Step for RustAnalyzer {
409410
cargo.arg("--workspace");
410411
cargo.arg("--exclude=xtask");
411412

413+
let mut skip_tests = vec![
414+
// FIXME: may need a fix from https://github.com/rust-lang/rust-analyzer/pull/19124.
415+
"config::tests::cargo_target_dir_subdir",
416+
// FIXME: I think this exercises cargo somehow?
417+
"tests::smoke_test_real_sysroot_cargo",
418+
// FIXME: config generation
419+
"config::tests::generate_config_documentation",
420+
"config::tests::generate_package_json_config",
421+
];
422+
skip_tests.extend(if self.host.starts_with("aarch64-apple") {
423+
vec![
424+
// FIXME: fails on `aarch64-apple` due to `cfg` differences
425+
"item_tree::tests::generics_with_attributes",
426+
"hover::tests::generic_params_disabled_by_cfg",
427+
]
428+
} else if self.host == "i686-pc-windows-gnu" {
429+
// FIXME: fails on `i686-mingw` due to multiple reasons. E.g. unsupport op on 32-bit
430+
// windows-gnu target but on a 64-bit host, i.e. ptr width being different is
431+
// unsupported.
432+
vec![
433+
// FIXME: failed to const eval on 32-bit windows-gnu running on 64-bit host maybe?
434+
"consteval::tests::add",
435+
"consteval::tests::anonymous_const_block",
436+
"consteval::tests::alignment",
437+
"consteval::tests::bit_op",
438+
"consteval::tests::associated_types",
439+
"consteval::tests::boxes",
440+
"consteval::tests::array_and_index",
441+
"consteval::tests::builtin_derive_macro",
442+
"consteval::tests::casts",
443+
"consteval::tests::const_generic_subst_assoc_const_impl",
444+
"consteval::tests::c_string",
445+
"consteval::tests::const_generic_subst_fn",
446+
"consteval::tests::const_impl_assoc",
447+
"consteval::tests::closure_clone",
448+
"consteval::tests::byte_string",
449+
"consteval::tests::closures",
450+
"consteval::tests::const_trait_assoc",
451+
"consteval::tests::coerce_unsized",
452+
"consteval::tests::consts",
453+
"consteval::tests::enums",
454+
"consteval::tests::floating_point",
455+
"consteval::tests::destructing_assignment",
456+
"consteval::tests::floating_point_casts",
457+
"consteval::tests::closure_and_impl_fn",
458+
"consteval::tests::extern_weak_statics",
459+
"consteval::tests::function_call",
460+
"consteval::tests::function_param_patterns",
461+
"consteval::tests::closure_capture_unsized_type",
462+
"consteval::tests::function_pointer",
463+
"consteval::tests::from_ne_bytes",
464+
"consteval::tests::function_pointer_in_constants",
465+
"consteval::tests::from_trait",
466+
"consteval::tests::ifs",
467+
"consteval::tests::generic_fn",
468+
"consteval::tests::dyn_trait",
469+
"consteval::tests::impl_trait",
470+
"consteval::tests::enum_variant_as_function",
471+
"consteval::tests::const_transfer_memory",
472+
"consteval::tests::intrinsics::allocator",
473+
"consteval::tests::function_traits",
474+
"consteval::tests::intrinsics::copy_nonoverlapping",
475+
"consteval::tests::intrinsics::ctlz",
476+
"consteval::tests::intrinsics::ctpop",
477+
"consteval::tests::intrinsics::cttz",
478+
"consteval::tests::intrinsics::const_eval_select",
479+
"consteval::tests::intrinsics::floating_point",
480+
"consteval::tests::for_loops",
481+
"consteval::tests::function_pointer_and_niche_optimization",
482+
"consteval::tests::intrinsics::likely",
483+
"consteval::tests::intrinsics::arith_offset",
484+
"consteval::tests::intrinsics::overflowing_add",
485+
"consteval::tests::intrinsics::atomic",
486+
"consteval::tests::intrinsics::rotate",
487+
"consteval::tests::intrinsics::copy",
488+
"consteval::tests::intrinsics::read_via_copy",
489+
"consteval::tests::intrinsics::saturating",
490+
"consteval::tests::intrinsics::needs_drop",
491+
"consteval::tests::intrinsics::size_of",
492+
"consteval::tests::intrinsics::simd",
493+
"consteval::tests::intrinsics::min_align_of_val",
494+
"consteval::tests::intrinsics::transmute",
495+
"consteval::tests::intrinsics::type_name",
496+
"consteval::tests::intrinsics::wrapping_add",
497+
"consteval::tests::intrinsics::write_bytes",
498+
"consteval::tests::intrinsics::write_via_move",
499+
"consteval::tests::let_else",
500+
"consteval::tests::layout_of_type_with_associated_type_field_defined_inside_body",
501+
"consteval::tests::loops",
502+
"consteval::tests::locals",
503+
"consteval::tests::intrinsics::offset",
504+
"consteval::tests::intrinsics::size_of_val",
505+
"consteval::tests::or_pattern",
506+
"consteval::tests::memory_limit",
507+
"consteval::tests::intrinsics::ptr_offset_from",
508+
"consteval::tests::intrinsics::discriminant_value",
509+
"consteval::tests::path_pattern_matching",
510+
"consteval::tests::overloaded_binop",
511+
"consteval::tests::overloaded_deref",
512+
"consteval::tests::overloaded_index",
513+
"consteval::tests::overloaded_deref_autoref",
514+
"consteval::tests::pattern_matching_ergonomics",
515+
"consteval::tests::pattern_matching_literal",
516+
"consteval::tests::pattern_matching_range",
517+
"consteval::tests::manual_fn_trait_impl",
518+
"consteval::tests::recursion",
519+
"consteval::tests::reference_autoderef",
520+
"consteval::tests::references",
521+
"consteval::tests::ranges",
522+
"consteval::tests::raw_pointer_equality",
523+
"consteval::tests::match_guards",
524+
"consteval::tests::structs",
525+
"consteval::tests::options",
526+
"consteval::tests::trait_method",
527+
"consteval::tests::trait_basic",
528+
"consteval::tests::pattern_matching_slice",
529+
"consteval::tests::string",
530+
"consteval::tests::trait_method_inside_block",
531+
"consteval::tests::statics",
532+
"consteval::tests::tuples",
533+
"consteval::tests::unions",
534+
"consteval::tests::result_layout_niche_optimization",
535+
"consteval::tests::unsized_field",
536+
"consteval::tests::try_block",
537+
"consteval::tests::try_operator",
538+
"mir::eval::tests::closure_capture_array_const_generic",
539+
"mir::eval::tests::closure_layout_in_rpit",
540+
"mir::eval::tests::drop_basic",
541+
"mir::eval::tests::closure_state",
542+
"mir::eval::tests::drop_in_place",
543+
"mir::eval::tests::field_with_associated_type",
544+
"mir::eval::tests::function_with_extern_c_abi",
545+
"mir::eval::tests::generic_impl_for_trait_with_generic_method",
546+
"mir::eval::tests::drop_if_let",
547+
"mir::eval::tests::drop_struct_field",
548+
"mir::eval::tests::index_of_slice_should_preserve_len",
549+
"mir::eval::tests::for_loop",
550+
"mir::eval::tests::manually_drop",
551+
"mir::eval::tests::from_fn",
552+
"mir::eval::tests::long_str_eq_same_prefix",
553+
"mir::eval::tests::posix_getenv",
554+
"mir::eval::tests::memcmp",
555+
"mir::eval::tests::panic_display",
556+
"mir::eval::tests::self_with_capital_s",
557+
"mir::eval::tests::short_circuit_operator",
558+
"mir::eval::tests::panic_fmt",
559+
"mir::eval::tests::regression_14966",
560+
"mir::eval::tests::posix_tls",
561+
"mir::eval::tests::specialization_array_clone",
562+
"mir::eval::tests::unix_write_stdout",
563+
"mir::eval::tests::syscalls",
564+
"tests::regression::regression_14456",
565+
"tests::simple::const_eval_array_repeat_expr",
566+
"tests::simple::const_eval_in_function_signature",
567+
"tests::simple::issue_14275",
568+
"tests::traits::array_length",
569+
"tests::traits::const_generics",
570+
// FIXME: annotation order seems to be different on `i686-mingw`
571+
"annotations::tests::runnable_annotation",
572+
"annotations::tests::struct_references_annotations",
573+
"annotations::tests::struct_and_trait_impls_annotations",
574+
"annotations::tests::method_annotations",
575+
// FIXME: const eval on hover not working, either shows infer `_` or unevaluated.
576+
"hover::tests::array_repeat_exp",
577+
"hover::tests::const_generic_negative_i8_literal",
578+
"hover::tests::hover_const_eval",
579+
"hover::tests::hover_const_eval_discriminant",
580+
"hover::tests::hover_const_eval_enum",
581+
"hover::tests::hover_const_eval_floating_point",
582+
"hover::tests::hover_const_static",
583+
"hover::tests::hover_const_pat",
584+
"hover::tests::hover_const_eval_slice",
585+
"hover::tests::hover_eval_complex_constants",
586+
"hover::tests::hover_unsigned_max_const",
587+
"hover::tests::i128_max",
588+
// FIXME: failed to const eval, formatting difference in const struct
589+
// (extra comma / reformatted?)
590+
"hover::tests::hover_const_eval_str",
591+
// FIXME: failed to const eval, extra path segment
592+
"hover::tests::hover_const_value",
593+
"hover::tests::hover_dollar_crate",
594+
"hover::tests::hover_dollar_crate stdout",
595+
// FIXME: failed to const eval, shows explicit `i32` on literal
596+
"hover::tests::hover_const_eval_dyn_trait",
597+
// FIXME: discriminant `= ?` problems
598+
"inlay_hints::discriminant::tests::datacarrying_mixed",
599+
"inlay_hints::discriminant::tests::fieldless",
600+
// FIXME: list order non-deterministic or different on `i686-mingw`?
601+
"runnables::tests::tests_are_unique",
602+
// FIXME: HTML element attribute order maybe non-deterministic or different on
603+
// `i686-mingw`?
604+
"syntax_highlighting::tests::test_rainbow_highlighting",
605+
// FIXME: enum discrim not evaluated?
606+
"handlers::explicit_enum_discriminant::tests::non_primitive_repr_non_data_bearing_add_discriminant",
607+
"tests::generated::doctest_explicit_enum_discriminant",
608+
// FIXME: import is different
609+
"handlers::add_explicit_type::tests::regression_issue_2922",
610+
"handlers::bool_to_enum::tests::field_enum_cross_file",
611+
// FIXME: assist no source changes
612+
"handlers::explicit_enum_discriminant::tests::primitive_repr_non_data_bearing_add_discriminant",
613+
// FIXME: code action not applicable
614+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_block_array",
615+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_block_recursive",
616+
"handlers::explicit_enum_discriminant::tests::primitive_repr_non_data_bearing_add_discriminant",
617+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_block_array",
618+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_block_recursive",
619+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_block_scalar_calculate_expr",
620+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_block_scalar_calculate_param_expr",
621+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_block_slice_single",
622+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_block_tuple",
623+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_const_block_eval_block_expr",
624+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_block_tuple_scalar_calculate_block_expr",
625+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_const_block_eval_expr",
626+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_const_block_expr",
627+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_const_expr",
628+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_const_fn_call_block_nested_builtin",
629+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_const_fn_call_builtin",
630+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_const_fn_call_tuple",
631+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_eval_const_block_expr_to_str_lit",
632+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_eval_const_if_expr_to_str_lit",
633+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_eval_const_call_expr_to_str_lit",
634+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_eval_const_block_macro_expr_to_str_lit",
635+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_eval_const_macro_expr_to_str_lit",
636+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_eval_const_match_expr_to_str_lit",
637+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_expr_as_str_lit",
638+
"handlers::inline_const_as_literal::tests::inline_const_as_literal_scalar_operators",
639+
// FIXME: assist is not applicable
640+
"tests::generated::doctest_inline_const_as_literal",
641+
// FIXME: order of `ex fn` are different?
642+
"render::tests::score_fn_type_and_name_match",
643+
// FIXME: false negatives in diagnostic tests
644+
"handlers::type_mismatch::tests::evaluate_const_generics_in_types",
645+
"handlers::mutability_errors::tests::or_pattern",
646+
]
647+
} else if self.host == "x86_64-apple-darwin" {
648+
vec![
649+
// FIXME: missing `#[cfg(never)]` on struct generic param
650+
"item_tree::tests::generics_with_attributes",
651+
// FIXME: `{unknown}` in generic param position
652+
"hover::tests::generic_params_disabled_by_cfg",
653+
]
654+
} else {
655+
vec![]
656+
});
657+
658+
let skip_tests = skip_tests.iter().map(|name| format!("--skip={name}")).collect::<Vec<_>>();
659+
let skip_tests = skip_tests.iter().map(|s| s.as_str()).collect::<Vec<_>>();
660+
412661
run_cargo_test(
413662
cargo,
414-
&[
415-
// FIXME: may need a fix from https://github.com/rust-lang/rust-analyzer/pull/19124.
416-
"--skip=config::tests::cargo_target_dir_subdir",
417-
],
663+
skip_tests.as_slice(),
418664
&[],
419665
"rust-analyzer",
420666
"rust-analyzer",

0 commit comments

Comments
 (0)