Skip to content

rustdoc-json-types: Rename and document Impl::synthetic #125177

Open
@aDotInTheVoid

Description

@aDotInTheVoid

"synthetic" impls arn't a really a term that are used, especially in user-facing documentation. It's quite confusing to users that we use this to refer to impl's of auto trait. It's lead to users beliving (and understandably so) that the JSON output doesn't contain wether an impl is auto or not. (eg, CC @zjp-CN).

We should rename this field to something more descriptive. An ititial proposal would be is_auto, but I'm not sure this is quite right, as it's the trait that's auto, not the impl. I'm open to suggestions for the field name.

While we're at it, we should document it and add tests.

Metadata

Metadata

Assignees

No one assigned

    Labels

    A-rustdoc-jsonArea: Rustdoc JSON backendC-enhancementCategory: An issue proposing an enhancement or a PR with one.T-rustdocRelevant to the rustdoc team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions