Skip to content

let_chains stabilization followups #140722

Open
@est31

Description

@est31

PR #132833 has stabilized let_chains on edition 2024, but that's not the whole story. As the stabilization report writes:

this stabilization PR only makes it possible to use let chains on 2024 without that feature gate, it doesn't mark that feature gate as stable/removed. I would propose to continue offering the let_chains feature (behind a feature gate) for a limited time (maybe 3 months after stabilization?) on older editions to allow nightly users to adopt edition 2024 at their own pace. After that, the feature gate shall be marked as stabilized, not removed, and replaced by an error on editions 2021 and below.

Currently there is a bunch of use by the components making up the compiler. Not all are subtrees, and we should try to minimize forced updates via subtrees.

Once this is all done:

  • remove usage of the feature gate from tests, either by upgrading the edition, or by removing the variant or the entire test
  • mark the feature gate as stabilized, remove gating, and introduce a <=2021 specific error when trying to use let_chains.

Metadata

Metadata

Assignees

No one assigned

    Labels

    C-tracking-issueCategory: An issue tracking the progress of sth. like the implementation of an RFCF-let_chains`#![feature(let_chains)]`T-compilerRelevant to the compiler team, which will review and decide on the PR/issue.

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions